faker - npm Package Compare versions

Comparing version 2.0.1 to 2.0.3

bower.json

 {
   "name": "faker",
-  "main": "faker.js",
+  "main": "./build/build/faker.js",
   "version": "2.0.0",
@@ -5,0 +5,0 @@ "homepage": "https://github.com/Marak/faker.js",

examples/node_min_test.js

@@ -7,63 +7,4 @@ #!/usr/bin/env node
 
-// console.log(faker.definitions.name.suffix)
+faker.locale = "en";
 
-//util.puts(JSON.stringify(card));
-
-faker.locale = "en_CA";
-
-console.log(faker.address.zipCode())
-
-return;
-var image = faker.image.image();
-console.log(image);
-
-return;
-
-
-var first = faker.name.firstName(),
-    last = faker.name.lastName();
-    
-console.log(first, last)
-console.log(faker.name.findName(first, last))
-console.log(faker.internet.userName(first, last))
-
-
-return;
-var phone_number = faker.phone.phoneNumber("(###) ###-####");
-console.log(phone_number)
-return;
-
-console.log(faker.address.state_abbr())
-return;
-
-console.log(faker.helpers.contextualCard())
-
-console.log(faker.helpers.createCard())
-
-return;
-
-console.log(faker.lorem.words())
-
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-return;
-
-/*
-faker.locale = "zh_CN";
-
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-console.log(faker.name.firstName() + " " + faker.name.lastName())
-*/
-
-
-
-return;
-var phone_number = faker.finance.transactionType();
-console.log(phone_number)
-
-console.log(faker.definitions)
-
-var phone_number = faker.company.catchPhrase();
-
+console.log(faker.helpers.contextualCard());

lib/name.js

 var faker = require('../index');
 
 var _name = {
+
     firstName: function () {
-        return faker.random.array_element(faker.definitions.name.first_name)
+      if (typeof faker.locales[faker.locale].name.male_first_name !== "undefined" && typeof faker.locales[faker.locale].name.female_first_name !== "undefined") {
+        // some locale datasets ( like ru ) have first_name split by gender. since the name.first_name field does not exist in these datasets,
+        // we must randomly pick a name from either gender array so faker.name.firstName will return the correct locale data ( and not fallback )
+        var rand = faker.random.number(1);
+        if (rand === 0) {
+          return faker.random.array_element(faker.locales[faker.locale].name.male_first_name)
+        } else {
+          return faker.random.array_element(faker.locales[faker.locale].name.female_first_name)
+        }
+      }
+      return faker.random.array_element(faker.definitions.name.first_name)
     },
 
     lastName: function () {
-      return faker.random.array_element(faker.definitions.name.last_name)
+      if (typeof faker.locales[faker.locale].name.male_last_name !== "undefined" && typeof faker.locales[faker.locale].name.female_last_name !== "undefined") {
+        // some locale datasets ( like ru ) have last_name split by gender. i have no idea how last names can have genders, but also i do not speak russian
+        // see above comment of firstName method
+        var rand = faker.random.number(1);
+        if (rand === 0) {
+          return faker.random.array_element(faker.locales[faker.locale].name.male_last_name);
+        } else {
+          return faker.random.array_element(faker.locales[faker.locale].name.female_last_name);
+        }
+      }
+      return faker.random.array_element(faker.definitions.name.last_name);
     },
@@ -11,0 +32,0 @@

package.json

 {
     "name": "faker",
     "description": "Generate massive amounts of fake contextual data",
-    "version": "2.0.1",
+    "version": "2.0.3",
     "contributors": [
@@ -6,0 +6,0 @@ "Marak Squires <[e-mail]>",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

3

decreased by-25%

Worsened metrics

Total package byte prevSize

3760649

decreased by-0.04%

Number of package files

90

decreased by-3.23%

Lines of code

145805

decreased by-0.04%

No dependency changes