faker - npm Package Compare versions

Comparing version 2.1.3 to 2.1.4

lib/helpers.js

@@ -42,3 +42,3 @@ var faker = require('../index');
     o = o || ["a", "b", "c"];
-    for (var j, x, i = o.length; i; j = faker.random.number(i), x = o[--i], o[i] = o[j], o[j] = x);
+    for (var j, x, i = o.length-1; i; j = faker.random.number(i), x = o[--i], o[i] = o[j], o[j] = x);
     return o;
@@ -45,0 +45,0 @@ };

package.json

 {
   "name": "faker",
   "description": "Generate massive amounts of fake contextual data",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "contributors": [
@@ -33,2 +33,2 @@ "Marak Squires <[e-mail]>",
   "main": "index.js"
-}
+}

test/helpers.unit.js

@@ -24,2 +24,12 @@ if (typeof module !== 'undefined') {
 
+    describe("shuffle()", function () {
+        it("the output is the same length as the input", function () {
+            sinon.spy(faker.random, 'number');
+            var shuffled = faker.helpers.shuffle(["a", "b"]);
+            assert.ok(shuffled.length === 2);
+            assert.ok(faker.random.number.calledWith(1));
+            faker.random.number.restore();
+        });
+    });
+
     describe("slugify()", function () {
@@ -26,0 +36,0 @@ it("removes unwanted characters from URI string", function () {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3771877

increased by0.04%

Number of package files

92

increased by1.1%

Lines of code

146014

increased by0.03%

No dependency changes