feathers - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

changelog.md

 ## Changelog
 
+__1.1.1__
+
+- Fix 404 not being properly thrown by REST provider ([#146](https://github.com/feathersjs/feathers/pull/146))
+
 __1.1.0__
@@ -4,0 +8,0 @@

lib/providers/rest/index.js

@@ -49,18 +49,16 @@ 'use strict';
       // GET / -> service.find(cb, params)
-      baseRoute.get.apply(baseRoute, middleware.concat(app.rest.find(service)));
+      baseRoute.get.apply(baseRoute, middleware.concat(app.rest.find(service), handler));
       // POST -> service.create(data, params, cb)
-      baseRoute.post.apply(baseRoute, middleware.concat(app.rest.create(service)));
+      baseRoute.post.apply(baseRoute, middleware.concat(app.rest.create(service), handler));
 
       // GET /:id -> service.get(id, params, cb)
-      idRoute.get.apply(idRoute, middleware.concat(app.rest.get(service)));
+      idRoute.get.apply(idRoute, middleware.concat(app.rest.get(service), handler));
       // PUT /:id -> service.update(id, data, params, cb)
-      idRoute.put.apply(idRoute, middleware.concat(app.rest.update(service)));
+      idRoute.put.apply(idRoute, middleware.concat(app.rest.update(service), handler));
       // PATCH /:id -> service.patch(id, data, params, callback)
-      idRoute.patch.apply(idRoute, middleware.concat(app.rest.patch(service)));
+      idRoute.patch.apply(idRoute, middleware.concat(app.rest.patch(service), handler));
       // DELETE /:id -> service.remove(id, params, cb)
-      idRoute.delete.apply(idRoute, middleware.concat(app.rest.remove(service)));
-
-      app.use(uri, handler);
+      idRoute.delete.apply(idRoute, middleware.concat(app.rest.remove(service), handler));
     });
   };
 };

package.json

 {
   "name": "feathers",
   "description": "Build Better APIs, Faster than Ever.",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "homepage": "http://feathersjs.com",
@@ -6,0 +6,0 @@ "repository": {

readme.md

@@ -6,5 +6,7 @@ <div style="width: 100%; text-align: center;">
 
-[![Join the chat at https://gitter.im/feathersjs/feathers](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/feathersjs/feathers?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![NPM](https://nodei.co/npm/feathers.png?downloads=true&stars=true)](https://nodei.co/npm/feathers/)
 
 [![Build Status](https://travis-ci.org/feathersjs/feathers.png?branch=master)](https://travis-ci.org/feathersjs/feathers)
+[![Code Climate](https://codeclimate.com/github/feathersjs/feathers.png)](https://codeclimate.com/github/feathersjs/feathers)
+[![Join the chat at https://gitter.im/feathersjs/feathers](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/feathersjs/feathers?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
@@ -19,3 +21,3 @@ Feathers is a real-time, micro-service web framework for NodeJS that gives you control over your data via RESTful resources, sockets and flexible plug-ins.
 
-Curious how it looks? Here is a full REST and real-time todo API that uses MongoDB:
+Want to see it in action? Here is a full REST and real-time todo API that uses MongoDB:
 
@@ -49,2 +51,13 @@ ```js
 
-and go to [http://localhost:3000/todos](http://localhost:3000/todos). Don't want to use MongoDB? Feathers has plugins for [many other databases](http://feathersjs.com/learn/) and you can easily [write your own adapters](http://feathersjs.com/quick-start/).
+and go to [http://localhost:3000/todos](http://localhost:3000/todos). That's all the code you need to have a full real-time CRUD API.
+
+Don't want to use MongoDB? Feathers has plugins for [many other databases](http://feathersjs.com/learn/) and you can easily [write your own adapters](http://feathersjs.com/quick-start/).
+
+## License
+
+[MIT](LICENSE)
+
+## Authors
+
+- [David Luecke](https://github.com/daffl)
+- [Eric Kryski](http://erickryski.com)

test/providers/rest.test.js

@@ -266,2 +266,10 @@ 'use strict';
 
+    it('throws a 404 for undefined route', function(done) {
+      request('http://localhost:4780/todo/foo/bar', function (error, response) {
+        assert.ok(response.statusCode === 404, 'Got Not Found code');
+
+        done(error);
+      });
+    });
+    
     it('empty response sets 204 status codes', function(done) {
@@ -268,0 +276,0 @@ request('http://localhost:4780/todo', function (error, response) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

132916

increased by50.91%

Number of package files

45

increased by45.16%

Lines of code

2215

increased by0.23%

Number of lines in readme file

61

increased by27.08%

No dependency changes