fela-dom - npm Package Compare versions

Comparing version 10.4.0 to 10.4.1

es/dom/connection/createNode.js

@@ -7,3 +7,2 @@ import objectReduce from 'fast-loops/lib/objectReduce';
       support = _ref.support;
-  var id = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : '';
 
@@ -13,3 +12,2 @@ var head = document.head || {};
   var node = document.createElement('style');
-  node.setAttribute('data-fela-id', id);
   node.setAttribute('data-fela-type', type);
@@ -16,0 +14,0 @@ node.type = 'text/css';

es/dom/connection/getNodeFromCache.js

@@ -20,3 +20,3 @@ import calculateNodeScore from './calculateNodeScore';
     var score = calculateNodeScore(attributes, renderer.mediaQueryOrder);
-    var node = queryNode(attributes, renderer.rendererId) || createNode(renderer.nodes, score, attributes, renderer.rendererId);
+    var node = queryNode(attributes) || createNode(renderer.nodes, score, attributes);
 
@@ -23,0 +23,0 @@ renderer.nodes[reference] = {

es/dom/connection/queryNode.js

@@ -9,7 +9,6 @@
 
-  var idQuery = '[data-fela-id="' + id + '"]';
   var mediaQuery = media ? '[media="' + media + '"]' : ':not([media])';
   var supportQuery = support ? '[data-fela-support="true"]' : ':not([data-fela-support="true"])';
 
-  return document.querySelector('[data-fela-type="' + type + '"]' + idQuery + supportQuery + mediaQuery);
+  return document.querySelector('[data-fela-type="' + type + '"]' + supportQuery + mediaQuery);
 }

es/dom/rehydrate.js

@@ -17,5 +17,3 @@ import arrayEach from 'fast-loops/lib/arrayEach';
 
-  var idQuery = '[data-fela-id="' + renderer.rendererId + '"]';
-
-  arrayEach(document.querySelectorAll('[data-fela-type]' + idQuery), function (node) {
+  arrayEach(document.querySelectorAll('[data-fela-type]'), function (node) {
     var rehydrationAttribute = node.getAttribute('data-fela-rehydration') || -1;
@@ -22,0 +20,0 @@ var rehydrationIndex = renderer.uniqueRuleIdentifier || parseInt(rehydrationAttribute, 10);

es/server/createStyleTagMarkup.js

 
 
 export default function createStyleTagMarkup(css, type) {
-  var rendererId = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : '';
-  var media = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : '';
-  var rehydrationIndex = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : -1;
-  var support = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
+  var media = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : '';
+  var rehydrationIndex = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : -1;
+  var support = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : false;
 
-  var idAttribute = ' data-fela-id="' + rendererId + '"';
   var mediaAttribute = media.length > 0 ? ' media="' + media + '"' : '';
   var supportAttribute = support ? ' data-fela-support="true"' : '';
 
-  return '<style type="text/css" data-fela-rehydration="' + rehydrationIndex + '" data-fela-type="' + type + '"' + idAttribute + supportAttribute + mediaAttribute + '>' + css + '</style>';
+  return '<style type="text/css" data-fela-rehydration="' + rehydrationIndex + '" data-fela-type="' + type + '"' + supportAttribute + mediaAttribute + '>' + css + '</style>';
 }

es/server/renderToMarkup.js

@@ -17,3 +17,3 @@ var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };
     if (cacheCluster[key].length > 0) {
-      markup += createStyleTagMarkup(cacheCluster[key], type, renderer.rendererId, '', rehydrationIndex);
+      markup += createStyleTagMarkup(cacheCluster[key], type, '', rehydrationIndex);
     }
@@ -27,3 +27,3 @@
   if (support) {
-    styleMarkup += createStyleTagMarkup(support, RULE_TYPE, renderer.rendererId, '', rehydrationIndex, true);
+    styleMarkup += createStyleTagMarkup(support, RULE_TYPE, '', rehydrationIndex, true);
   }
@@ -36,3 +36,3 @@
     if (cacheCluster.mediaRules[media] && cacheCluster.mediaRules[media].length > 0) {
-      markup += createStyleTagMarkup(cacheCluster.mediaRules[media], RULE_TYPE, renderer.rendererId, media, rehydrationIndex);
+      markup += createStyleTagMarkup(cacheCluster.mediaRules[media], RULE_TYPE, media, rehydrationIndex);
     }
@@ -45,3 +45,3 @@
       if (mediaSupport.length > 0) {
-        markup += createStyleTagMarkup(mediaSupport, RULE_TYPE, renderer.rendererId, media, rehydrationIndex, true);
+        markup += createStyleTagMarkup(mediaSupport, RULE_TYPE, media, rehydrationIndex, true);
       }
@@ -48,0 +48,0 @@ }

lib/dom/connection/createNode.js

@@ -18,3 +18,2 @@ 'use strict';
       support = _ref.support;
-  var id = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : '';
 
@@ -24,3 +23,2 @@ var head = document.head || {};
   var node = document.createElement('style');
-  node.setAttribute('data-fela-id', id);
   node.setAttribute('data-fela-type', type);
@@ -27,0 +25,0 @@ node.type = 'text/css';

lib/dom/connection/getNodeFromCache.js

@@ -36,3 +36,3 @@ 'use strict';
     var score = (0, _calculateNodeScore2.default)(attributes, renderer.mediaQueryOrder);
-    var node = (0, _queryNode2.default)(attributes, renderer.rendererId) || (0, _createNode2.default)(renderer.nodes, score, attributes, renderer.rendererId);
+    var node = (0, _queryNode2.default)(attributes) || (0, _createNode2.default)(renderer.nodes, score, attributes);
 
@@ -39,0 +39,0 @@ renderer.nodes[reference] = {

lib/dom/connection/queryNode.js

@@ -13,7 +13,6 @@ 'use strict';
 
-  var idQuery = '[data-fela-id="' + id + '"]';
   var mediaQuery = media ? '[media="' + media + '"]' : ':not([media])';
   var supportQuery = support ? '[data-fela-support="true"]' : ':not([data-fela-support="true"])';
 
-  return document.querySelector('[data-fela-type="' + type + '"]' + idQuery + supportQuery + mediaQuery);
+  return document.querySelector('[data-fela-type="' + type + '"]' + supportQuery + mediaQuery);
 }

lib/dom/rehydrate.js

@@ -39,5 +39,3 @@ 'use strict';
 
-  var idQuery = '[data-fela-id="' + renderer.rendererId + '"]';
-
-  (0, _arrayEach2.default)(document.querySelectorAll('[data-fela-type]' + idQuery), function (node) {
+  (0, _arrayEach2.default)(document.querySelectorAll('[data-fela-type]'), function (node) {
     var rehydrationAttribute = node.getAttribute('data-fela-rehydration') || -1;
@@ -44,0 +42,0 @@ var rehydrationIndex = renderer.uniqueRuleIdentifier || parseInt(rehydrationAttribute, 10);

lib/server/createStyleTagMarkup.js

@@ -8,12 +8,10 @@ 'use strict';
 function createStyleTagMarkup(css, type) {
-  var rendererId = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : '';
-  var media = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : '';
-  var rehydrationIndex = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : -1;
-  var support = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : false;
+  var media = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : '';
+  var rehydrationIndex = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : -1;
+  var support = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : false;
 
-  var idAttribute = ' data-fela-id="' + rendererId + '"';
   var mediaAttribute = media.length > 0 ? ' media="' + media + '"' : '';
   var supportAttribute = support ? ' data-fela-support="true"' : '';
 
-  return '<style type="text/css" data-fela-rehydration="' + rehydrationIndex + '" data-fela-type="' + type + '"' + idAttribute + supportAttribute + mediaAttribute + '>' + css + '</style>';
+  return '<style type="text/css" data-fela-rehydration="' + rehydrationIndex + '" data-fela-type="' + type + '"' + supportAttribute + mediaAttribute + '>' + css + '</style>';
 }

lib/server/renderToMarkup.js

@@ -38,3 +38,3 @@ 'use strict';
     if (cacheCluster[key].length > 0) {
-      markup += (0, _createStyleTagMarkup2.default)(cacheCluster[key], type, renderer.rendererId, '', rehydrationIndex);
+      markup += (0, _createStyleTagMarkup2.default)(cacheCluster[key], type, '', rehydrationIndex);
     }
@@ -48,3 +48,3 @@
   if (support) {
-    styleMarkup += (0, _createStyleTagMarkup2.default)(support, _felaUtils.RULE_TYPE, renderer.rendererId, '', rehydrationIndex, true);
+    styleMarkup += (0, _createStyleTagMarkup2.default)(support, _felaUtils.RULE_TYPE, '', rehydrationIndex, true);
   }
@@ -57,3 +57,3 @@
     if (cacheCluster.mediaRules[media] && cacheCluster.mediaRules[media].length > 0) {
-      markup += (0, _createStyleTagMarkup2.default)(cacheCluster.mediaRules[media], _felaUtils.RULE_TYPE, renderer.rendererId, media, rehydrationIndex);
+      markup += (0, _createStyleTagMarkup2.default)(cacheCluster.mediaRules[media], _felaUtils.RULE_TYPE, media, rehydrationIndex);
     }
@@ -66,3 +66,3 @@
       if (mediaSupport.length > 0) {
-        markup += (0, _createStyleTagMarkup2.default)(mediaSupport, _felaUtils.RULE_TYPE, renderer.rendererId, media, rehydrationIndex, true);
+        markup += (0, _createStyleTagMarkup2.default)(mediaSupport, _felaUtils.RULE_TYPE, media, rehydrationIndex, true);
       }
@@ -69,0 +69,0 @@ }

package.json

 {
   "name": "fela-dom",
-  "version": "10.4.0",
+  "version": "10.4.1",
   "description": "Fela package for working with the DOM",
@@ -29,10 +29,10 @@ "main": "lib/index.js",
     "fast-loops": "^1.0.1",
-    "fela-utils": "^10.4.0"
+    "fela-utils": "^10.4.1"
   },
   "devDependencies": {
-    "fela": "^10.4.0",
-    "fela-preset-web": "^10.4.0",
-    "fela-tools": "^10.4.0"
+    "fela": "^10.4.1",
+    "fela-preset-web": "^10.4.1",
+    "fela-tools": "^10.4.1"
   },
-  "gitHead": "a064f897f41a6f60934265b686c53756f4ee71b8"
+  "gitHead": "2955dd7100c03c4fc9e958fc904ed9ea642100f8"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

51475

decreased by-2.07%

Lines of code

1101

decreased by-1.08%

Dependency changes

• Updatedfela-utils@^10.4.1