fh-forms - npm Package Compare versions

Comparing version 0.2.21 to 0.2.22

lib/impl/amqpservice.js

@@ -11,8 +11,3 @@ var fhamqpjs = require('fh-amqp-js');
 
-var fh_amqp_enabled = process.env.FH_AMQP_APP_ENABLED || false;
-var fh_amqp_user = process.env.FH_AMQP_USER;
-var fh_amqp_pass = process.env.FH_AMQP_PASS;
-var fh_amqp_nodes = process.env.FH_AMQP_NODES;
-var fh_amqp_conn_max = process.env.FH_AMQP_CONN_MAX;
-var fh_amqp_vhost = process.env.FH_AMQP_VHOST;
+
 var fh_amqp_cluster_node_pattern = "amqp://{{user}}:{{pass}}@{{nodes}}/{{vhost}}";
@@ -25,2 +20,9 @@
 module.exports = function () {
+  var fh_amqp_enabled = process.env.FH_AMQP_APP_ENABLED || false;
+  var fh_amqp_user = process.env.FH_AMQP_USER;
+  var fh_amqp_pass = process.env.FH_AMQP_PASS;
+  var fh_amqp_nodes = process.env.FH_AMQP_NODES;
+  var fh_amqp_conn_max = process.env.FH_AMQP_CONN_MAX;
+  var fh_amqp_vhost = process.env.FH_AMQP_VHOST;
+
   var fh_amqp_cluster_node;
@@ -27,0 +29,0 @@ if (fh_amqp_enabled &&

lib/impl/notification.js

 var amqpService = require('./amqpservice.js');
 var amqp;
-var amqpManager = amqpService();
+var amqpManager;
 
 exports.initNotifications = function (cb) {
   if(amqp) return cb();
+  if(!amqpManager) {
+    amqpManager = amqpService();
+  }
   amqpManager.startUp(function (err, pamqp) {
@@ -47,2 +50,3 @@ if(err) return cb(err);
   msg.appId = formSubmission.appId;
+  msg.attachmentUrl = getAttachmentUrl(formSubmission._id);
   msg.formName = formName || "UNKNOWN FORM NAME";
@@ -73,6 +77,10 @@ msg.submissionStatus = formSubmission.status;
 
+function getAttachmentUrl(id) {
+  return '<<<host>>>/api/v2/forms/submission/' + id + '.pdf';
+}
+
 function getStringValue(valueObj, type) {
   // if photo/file/sig return URL
   if (["photo", "signature", "file"].indexOf(type) >= 0) {
-    return "api/v2/forms/submission/file/" + valueObj.toString();
+    return "<<<host>>>/api/v2/forms/submission/file/" + valueObj.toString();
   }
@@ -79,0 +87,0 @@

lib/impl/updateForm.js

@@ -135,3 +135,4 @@ var async = require('async');
           "description": formData.description,
-          "pages": pageIds
+          "pages": pageIds,
+          "subscribers": formData.subscribers
         });
@@ -138,0 +139,0 @@ return cb(undefined, form);

package.json

 {
   "name": "fh-forms",
-  "version": "0.2.21",
+  "version": "0.2.22",
   "description": "Cloud Forms API for form submission",
@@ -5,0 +5,0 @@ "main": "lib/forms.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2152666

increased by983.66%

Number of package files

84

increased by147.06%

Lines of code

18783

increased by250.43%

Number of medium quality alerts

2

decreased by-33.33%

Number of lines in readme file

5

increased byInfinity%

Worsened metrics

Number of low supply chain risk alerts

170

increased by1788.89%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes