fh-logger - npm Package Compare versions

Comparing version 0.3.0 to 0.4.0

lib/fh_logger.js

@@ -31,3 +31,4 @@ /*
 function parseConfig(loggerConfig) {
-  return typeof loggerConfig === 'string' ? JSON.parse(loggerConfig) : loggerConfig;
+  var config = typeof loggerConfig !== 'string' ? JSON.stringify(loggerConfig) : loggerConfig;
+  return JSON.parse(config);
 }
@@ -34,0 +35,0 @@

package.json

 {
   "name": "fh-logger",
   "description": "Enables a simple way of configuring and creating loggers, configured with request serializers, including clustering information.",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "repository": {
@@ -6,0 +6,0 @@ "type": "git",

test/test_fh_logger.js

@@ -40,2 +40,11 @@ /*
 
+    describe('should make copy of provided config', function() {
+      it('config should not be modified when passed to createLogger function', function() {
+        var config = {name: 'simple'};
+        expect(Object.keys(config).length).to.equal(1);
+        var logger = fh_logger.createLogger(config);
+        expect(Object.keys(config).length).to.equal(1);
+      });
+    });
+
     describe('with Bunyan defaults', function() {
@@ -42,0 +51,0 @@ var logger;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

37817

increased by1.12%

Lines of code

617

increased by1.48%

No dependency changes