fh-sync-js - npm Package Compare versions

Comparing version 1.3.2 to 1.4.0

CHANGELOG.md

 # Changelog - fh-sync-js lib
 
+
+## 1.4.0 - 2019-04-15
+## Change
+- Change in the Storage Adapter in order to allow it works with IOS 12 webkit update. (IOS 12 still not supported by RHMAP) 
+
 ## 1.3.2 - 2018-09-27
@@ -4,0 +9,0 @@ ## Fix

libs/lawnchair/lawnchair.js

@@ -88,3 +88,3 @@ /**
   // methods required to implement a lawnchair adapter
-  var implementing = 'adapter valid init keys save batch get exists all remove nuke'.split(' ')
+  var implementing = 'adapter valid init keys close save batch get exists all remove nuke'.split(' ')
     ,   indexOf = this.prototype.indexOf
@@ -91,0 +91,0 @@ // mix in the adapter

libs/lawnchair/lawnchairIndexDbAdapter.js

@@ -15,5 +15,11 @@ module.exports = function (Lawnchair) {
     return {
+      valid: function () { return !!getIDB(); },
+      
+      close: function () {
+        if (this.db) {
+          this.db.close();
+        }
+        return this;
+      },
 
-      valid: function() { return !!getIDB(); },
-
       init:function(options, callback) {
@@ -29,4 +35,4 @@ this.idb = getIDB();
         //END CHANGE
-        request.onupgradeneeded = function(event){
-          self.store = request.result.createObjectStore("teststore", { autoIncrement: true} );
+        request.onupgradeneeded = function (event) {
+          self.store = request.result.createObjectStore("teststore", { autoIncrement: true });
           for (var i = 0; i < self.waiting.length; i++) {
@@ -37,15 +43,14 @@ self.waiting[i].call(self);
           win();
-        }
+        };
 
-        request.onsuccess = function(event) {
+        request.onsuccess = function (event) {
           self.db = request.result;
 
+          if (self.db.version != "2.0") {
+            if (typeof self.db.setVersion == 'function') {
 
-          if(self.db.version != "2.0") {
-            if(typeof self.db.setVersion == 'function'){
-
               var setVrequest = self.db.setVersion("2.0");
               // onsuccess is the only place we can create Object Stores
-              setVrequest.onsuccess = function(e) {
-                self.store = self.db.createObjectStore("teststore", { autoIncrement: true} );
+              setVrequest.onsuccess = function (e) {
+                self.store = self.db.createObjectStore("teststore", { autoIncrement: true });
                 for (var i = 0; i < self.waiting.length; i++) {
@@ -57,4 +62,4 @@ self.waiting[i].call(self);
               };
-              setVrequest.onerror = function(e) {
-              // console.log("Failed to create objectstore " + e);
+              setVrequest.onerror = function (e) {
+                // console.log("Failed to create objectstore " + e);
                 fail(e);
@@ -72,3 +77,4 @@ }
           }
-        }
+        };
+
         request.onerror = fail;
@@ -86,3 +92,8 @@ },
         var self = this;
-        var win  = function (e) { if (callback) { obj.key = e.target.result; self.lambda(callback).call(self, obj) }};
+        var win = function (e) {
+          if (callback) {
+            obj.key = e.target.result;
+            self.lambda(callback).call(self, obj)
+          }
+        };
         var accessType = "readwrite";
@@ -89,0 +100,0 @@ var trans = this.db.transaction(["teststore"],accessType);

npm-shrinkwrap.json

 {
   "name": "fh-sync-js",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "dependencies": {
@@ -5,0 +5,0 @@ "loglevel": {

package.json

 {
   "name": "fh-sync-js",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "Javascript client for fh-sync offline synchronization library",
@@ -5,0 +5,0 @@ "main": "src/index.js",

src/sync-client.js

@@ -976,3 +976,3 @@ var CryptoJS = require("../libs/generated/crypto");
     
-    getStorageAdapter: function(dataset_id, isSave, cb){
+    getStorageAdapter: function (dataset_id, isSave, cb) {
       var onFail = function(msg, err){
@@ -983,2 +983,3 @@ var errMsg = (isSave?'save to': 'load from' ) + ' local storage failed msg: ' + msg + ' err: ' + err;
       };
+     
       Lawnchair({
@@ -1000,5 +1001,9 @@ name: id,
         self.getStorageAdapter(dataset_id, true, function(err, storage){
-          storage.save({key:"dataset_" + dataset_id, val:dataset}, function(){
+          storage.save({ key: "dataset_" + dataset_id, val: dataset }, function () {
+            //close connection [at this point, for indexed DB only]
+            if (typeof storage.close === 'function') {
+              storage.close();
+            }
             //save success
-            if(cb) {
+            if (cb) {
               return cb();
@@ -1005,0 +1010,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Minified code

Quality

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

1

decreased by-50%

Number of low supply chain risk alerts

1

decreased by-80%

Number of medium supply chain risk alerts

1

decreased by-75%

Worsened metrics

Total package byte prevSize

291808

decreased by-42.67%

Number of package files

36

decreased by-5.26%

Lines of code

7905

decreased by-37.16%

No dependency changes