fh-wfm-mediator - npm Package Compare versions

Comparing version 0.1.0-rc3 to 0.1.0-rc4

lib/mediator.js

@@ -7,3 +7,2 @@ 'use strict';
 
-
 /**
@@ -79,4 +78,4 @@ * A version of {@link once} that returns a Promise
   function unsubscribe() {
-    self.remove(topics.done, subs.done.id);
-    self.remove(topics.error, subs.error.id);
+    self.remove(topics.done, subs.done);
+    self.remove(topics.error, subs.error);
   }
@@ -90,14 +89,15 @@
   }
+
+  // must setup subscriptions before publish
+  var resultPromise = new Promise(function(resolve, reject) {
+    subs.done = self.once(topics.done, resolve);
+    subs.error = self.once(topics.error, reject);
+  });
+
   self.publish.apply(mediator, args);
 
-  return new Promise(function(resolve, reject) {
-    subs.done = self.once(topics.done, resolve);
-    subs.error = mediator.once(topics.error, reject);
-  })
+  return resultPromise
   .timeout(options.timeout, new Error('Mediator request timeout for topic ' +  topic))
-  .tap(unsubscribe)
-  .catch(function(e) {
+  .finally(function() {
     unsubscribe();
-    // still forward the rejection to clients
-    throw e;
   });
@@ -104,0 +104,0 @@ };

package.json

 {
   "name": "fh-wfm-mediator",
-  "version": "0.1.0-rc3",
+  "version": "0.1.0-rc4",
   "description": "An implementation of the mediator pattern for use with WFM",
@@ -5,0 +5,0 @@ "main": "lib/angular/mediator-ng.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

37501

decreased by-58.91%

Number of package files

16

decreased by-56.76%

Lines of code

705

decreased by-52.36%

No dependency changes