firebase-admin - npm Package Compare versions

Comparing version 1.0.8 to 1.0.9

account.js

@@ -37,3 +37,3 @@
     } else if (body.error) {
-      deferred.reject(new Error(body.error));
+      deferred.reject(new Error('Firebase error: ' + body.error));
     } else if (body.success === false) {
@@ -86,3 +86,3 @@ deferred.reject(new Error('Bad credentials or server error.'));
     } else if (body.error) {
-      deferred.reject(new Error(body.error));
+      deferred.reject(new Error('Firebase error: ' + body.error));
     } else if (body.success === false) {
@@ -168,3 +168,3 @@ deferred.reject(new Error('Bad credentials or server error.'));
     } else if (body.error) {
-      deferred.reject(new Error(body.error));
+      deferred.reject(new Error('Firebase error: ' + body.error));
     } else if (body.success === false) {
@@ -171,0 +171,0 @@ deferred.reject(new Error('Bad credentials or server error.'));

instance.js

@@ -21,3 +21,3 @@
  * @see {FirebaseAccount#getDatabase}
- * @protected 
+ * @protected
  * @constructor
@@ -195,31 +195,36 @@ * @param {String} name The name of the Firebase.
 
-  if (!this.authTokens || this.authTokens.indexOf(token) === -1) {
-    return Q.reject(
-      new Error('No such token exists on firebase ' + this.toString())
-    );
-  }
+  return this.getAuthTokens()
+  .then(function(tokens) {
 
-  var deferred = Q.defer();
+    if (!Array.isArray(tokens) || tokens.indexOf(token) === -1) {
+      return Q.reject(
+        new Error('No such token exists on firebase ' + this.toString())
+      );
+    }
 
-  request.del({
-    url: 'https://' + this.name + '.firebaseio.com/.settings/secrets/' + token + '.json',
-    qs: {
-      auth: this.personalToken,
-    },
-    json: true
-  }, function(err, response, body) {
-    if (err) {
-      deferred.reject(err);
-    } else if (response.statusCode > 299) {
-      deferred.reject(new Error(response.statusCode));
-    } else if (body && body.error) {
-      deferred.reject(new Error(body.error));
-    } else {
-      this.authTokens.splice(this.authTokens.indexOf(token), 1);
-      deferred.resolve(this);
-    }
+    var deferred = Q.defer();
+
+    request.del({
+      url: 'https://' + this.name + '.firebaseio.com/.settings/secrets/' + token + '.json',
+      qs: {
+        auth: this.personalToken,
+      },
+      json: true
+    }, function(err, response, body) {
+      if (err) {
+        deferred.reject(err);
+      } else if (response.statusCode > 299) {
+        deferred.reject(new Error(response.statusCode));
+      } else if (body && body.error) {
+        deferred.reject(new Error(body.error));
+      } else {
+        this.authTokens.splice(this.authTokens.indexOf(token), 1);
+        deferred.resolve(this);
+      }
+    }.bind(this));
+
+    return deferred.promise;
+
   }.bind(this));
 
-  return deferred.promise;
-
 };
@@ -232,3 +237,3 @@
  * @returns {external:Promise} A promise that resolves with an Object
- * containing the rules if they're retrieved successfully and 
+ * containing the rules if they're retrieved successfully and
  * rejects with an Error if there's an error.
@@ -243,3 +248,3 @@ * @example
 FirebaseInstance.prototype.getRules = function() {
-  
+
   if (this.deleted) {
@@ -250,3 +255,3 @@ return Q.reject(
   }
- 
+
   var deferred = Q.defer();
@@ -284,3 +289,3 @@
  * @returns {external:Promise} A promise that resolves if the rules are changed
- * successfully and rejects with an Error if there's an error. 
+ * successfully and rejects with an Error if there's an error.
  * @example
@@ -303,3 +308,3 @@ * instance.setRules({
   }
- 
+
   if (!(newRules.rules && Object.keys(newRules).length === 1)) {
@@ -319,3 +324,3 @@ newRules = {
     json: true,
-    body: newRules 
+    body: newRules
   }, function(err, response, body) {
@@ -322,0 +327,0 @@ if (err) {

package.json

 {
   "name": "firebase-admin",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "Programmatically instantiate and modify Firebase instances.",
@@ -25,2 +25,3 @@ "keywords": [
   "main": "account.js",
+  "bin": "bin/firebase-admin.js",
   "scripts": {
@@ -33,3 +34,4 @@ "test": "./script/test.bash",
     "q": "^1.0.1",
-    "firebase": "^1.0.17"
+    "firebase": "^1.0.17",
+    "optometrist": "^0.1.3"
   },
@@ -36,0 +38,0 @@ "devDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

31567

increased by20.54%

Number of package files

16

increased by6.67%

Lines of code

830

increased by28.48%

Worsened metrics

Dependency count

4

increased by33.33%

Dependency changes

• + Addedoptometrist@^0.1.3

• + Addedoptometrist@0.1.3(transitive)