fluent-logger - npm Package Compare versions

Comparing version 3.3.0 to 3.3.1

CHANGELOG.md

 # v3.x
 
+## v3.3.1 - 2019-02-19
+
+### Fixes
+
+* Set up default error handler for winston #136
+* Flush sendQueue after reconnect #136
+
 ## v3.3.0 - 2019-01-31
@@ -4,0 +11,0 @@

lib/sender.js

@@ -454,2 +454,3 @@ 'use strict';
         this._connect(() => {
+          this._flushSendQueue()
           this.internalLogger.info('Fluentd reconnection finished!!');
@@ -456,0 +457,0 @@ });

lib/testHelper.js

@@ -175,3 +175,6 @@ 'use strict';
   listen(callback) {
-    this._server.listen(() => {
+    let options = {
+      port: this._options.port
+    };
+    this._server.listen(options, () => {
       this._port = this._server.address().port;
@@ -178,0 +181,0 @@ callback();

lib/winston.js

@@ -35,2 +35,3 @@ 'use strict';
     this.sender = new FluentSender(tag, options);
+    this.sender._setupErrorHandler();
   }
@@ -37,0 +38,0 @@

package.json

 {
   "name": "fluent-logger",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "main": "./lib/index.js",
@@ -5,0 +5,0 @@ "scripts": {

test/test.sender.js

@@ -293,2 +293,28 @@ 'use strict';
 
+  it('should flush queue on reconnect', (done) => {
+    const s = new FluentSender('debug', Object.assign({}, clientOptions, {
+      port: 43210,
+      reconnectInterval: 20,
+      internalLogger: {
+        info: () => {},
+        error: () => {}
+      }
+    }));
+    s._setupErrorHandler();
+    s.emit('record', { number: 1});
+    s.emit('record', { number: 2});
+    setTimeout(() => {
+      runServer({requireAckResponse: true, port: 43210}, serverOptions, (server, finish) => {
+        setTimeout(() => {
+          finish((data) => {
+            expect(data.length).to.be.equal(2);
+            expect(data[0].data.number).to.be.equal(1);
+            expect(data[1].data.number).to.be.equal(2);
+            done();
+          });
+        }, 20);
+      });
+    }, 100);
+  });
+
   [
@@ -600,2 +626,34 @@ {
 
+  it('should flush queue on reconnect for stream', (done) => {
+    const s = new FluentSender('debug', Object.assign({}, clientOptions, {
+      port: 43210,
+      reconnectInterval: 20,
+      internalLogger: {
+        info: () => {},
+        error: () => {}
+      }
+    }));
+    s._setupErrorHandler();
+    const ss = s.toStream('record');
+    const pt = new stream.PassThrough();
+    pt.pipe(ss);
+    pt.push('data1\n');
+    pt.push('data2\ndata');
+    pt.push('3\ndata4\n');
+    pt.end();
+    setTimeout(() => {
+      runServer({port: 43210}, serverOptions, (server, finish) => {
+        setTimeout(() => {
+          finish((data) => {
+            expect(data[0].data.message).to.be.equal('data1');
+            expect(data[1].data.message).to.be.equal('data2');
+            expect(data[2].data.message).to.be.equal('data3');
+            expect(data[3].data.message).to.be.equal('data4');
+            done();
+          });
+        }, 20);
+      });
+    }, 100);
+  });
+
   it('should process messages step by step on requireAckResponse=true', (done) => {
@@ -602,0 +660,0 @@ runServer({ requireAckResponse: true }, serverOptions, (server, finish) => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

140915

increased by1.45%

Lines of code

2021

increased by3.11%

No dependency changes