fontawesome-iconpicker - npm Package Compare versions

Comparing version 3.1.0 to 3.1.1

Gruntfile.js

 'use strict';
+
+const jsBanner = `/*!
+ * Font Awesome Icon Picker
+ * https://farbelous.github.io/fontawesome-iconpicker/
+ *
+ * @author Javi Aguilar, itsjavi.com
+ * @license MIT License
+ * @see https://github.com/farbelous/fontawesome-iconpicker/blob/master/LICENSE
+ */
+ `;
+
 module.exports = function(grunt) {
@@ -105,7 +116,7 @@ const parsedIconPicker = 'prod/src/js/iconpicker.js';
                     beautify: false,
-                    preserveComments: 'some'
+                    comments: 'some',
+                    banner: jsBanner
                 },
                 files: {
                     'dist/js/fontawesome-iconpicker.min.js': [
-                        'src/js/license.js',
                         'src/js/jquery.ui.pos.js',
@@ -120,7 +131,7 @@ parsedIconPicker
                     beautify: true,
-                    preserveComments: 'some'
+                    comments: 'some',
+                    banner: jsBanner
                 },
                 files: {
                     'dist/js/fontawesome-iconpicker.js': [
-                        'src/js/license.js',
                         'src/js/jquery.ui.pos.js',
@@ -127,0 +138,0 @@ parsedIconPicker

package.json

 {
   "name": "fontawesome-iconpicker",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Font Awesome Icon Picker plugin for Twitter Bootstrap",
@@ -24,14 +24,14 @@ "homepage": "https://farbelous.github.io/fontawesome-iconpicker/",
   "devDependencies": {
-    "grunt": "~0.4.5",
-    "grunt-contrib-clean": "~0.5.0",
-    "grunt-contrib-concat": "~0.4.0",
-    "grunt-contrib-jshint": "~0.10.0",
-    "grunt-contrib-less": "~0.11.2",
-    "grunt-contrib-uglify": "~0.5.0",
-    "grunt-contrib-watch": "~0.6.1",
-    "grunt-http-download": "^0.1.0",
-    "grunt-jsbeautifier": "~0.2.7",
-    "grunt-string-replace": "^1.3.1",
-    "grunt-yaml": "^0.4.2"
+    "grunt": "^1.0.3",
+    "grunt-contrib-clean": "^0.5",
+    "grunt-contrib-concat": "^0.4",
+    "grunt-contrib-jshint": "^2.0.0",
+    "grunt-contrib-less": "^2.0.0",
+    "grunt-contrib-uglify": "^4.0.0",
+    "grunt-contrib-watch": "^1.1.0",
+    "grunt-http-download": "^0.1",
+    "grunt-jsbeautifier": "^0.2",
+    "grunt-string-replace": "^1.3",
+    "grunt-yaml": "^0.4"
   }
 }

src/js/iconpicker.js

@@ -1,9 +0,8 @@
-/*
+/*!
  * Font Awesome Icon Picker
  * https://farbelous.github.io/fontawesome-iconpicker/
  *
- * Originally written by (c) 2016 Javi Aguilar
- * Licensed under the MIT License
- * https://github.com/farbelous/fontawesome-iconpicker/blob/master/LICENSE
- *
+ * @author Javi Aguilar, itsjavi.com
+ * @license MIT License
+ * @see https://github.com/farbelous/fontawesome-iconpicker/blob/master/LICENSE
  */
@@ -152,3 +151,3 @@
                 iconpicker: '<div class="iconpicker"><div class="iconpicker-items"></div></div>',
-                iconpickerItem: '<a role="button" href="#" class="iconpicker-item"><i></i></a>',
+                iconpickerItem: '<a role="button" href="javascript:;" class="iconpicker-item"><i></i></a>',
             }
@@ -243,5 +242,7 @@ };
 
+                var $itemElementTemplate = $(this.options.templates.iconpickerItem);
+                var $elementsToAppend = [];
                 for (var i in this.options.icons) {
                     if (typeof this.options.icons[i].title === 'string') {
-                        var itemElement = $(this.options.templates.iconpickerItem);
+                        var itemElement = $itemElementTemplate.clone();
                         itemElement.find('i')
@@ -251,5 +252,4 @@ .addClass(this.options.fullClassFormatter(this.options.icons[i].title));
                             .on('click.iconpicker', itemClickFn);
-                        this.iconpicker.find('.iconpicker-items').append(itemElement
-                            .attr('title', '.' + this.options.icons[i].title));
 
+                        itemElement.attr('title', '.' + this.options.icons[i].title);
                         if (this.options.icons[i].searchTerms.length > 0) {
@@ -260,9 +260,8 @@ var searchTerms = '';
                             }
-                            this.iconpicker.find('.iconpicker-items').append(itemElement
-                                .attr('data-search-terms', searchTerms));
+                            itemElement.attr('data-search-terms', searchTerms);
                         }
-
+                        $elementsToAppend.push(itemElement);
                     }
                 }
-
+                this.iconpicker.find('.iconpicker-items').append($elementsToAppend);
                 this.popover.find('.popover-content').append(this.iconpicker);
@@ -269,0 +268,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

397131

increased by4.28%

Number of downloads

4618

increased by2.3%

Number of package files

24

increased by50%

Number of low license alerts

0

decreased by-100%

License quality

100

increased by25%

Worsened metrics

Lines of code

6639

decreased by-0.29%

No dependency changes