formidable - npm Package Compare versions

Comparing version 1.0.4 to 1.0.5

lib/incoming_form.js

@@ -297,4 +297,4 @@ if (global.GENTLY) require = GENTLY.hijack(require);
       var filename = self._fileName(headerValue);
-      if (filename) {
-        part.filename = filename;
+      if (filename !== undefined) {
+        part.filename = filename || part.name;
       }
@@ -330,3 +330,3 @@ } else if (headerField == 'content-type') {
 IncomingForm.prototype._fileName = function(headerValue) {
-  var m = headerValue.match(/filename="(.+?)"($|; )/i)
+  var m = headerValue.match(/filename="(.*?)"($|; )/i)
   if (!m) return;
@@ -333,0 +333,0 @@

lib/multipart_parser.js

@@ -52,2 +52,9 @@ var Buffer = require('buffer').Buffer,
 
+MultipartParser.stateToString = function(stateNumber) {
+  for (var state in S) {
+    var number = S[state];
+    if (number === stateNumber) return state;
+  }
+};
+
 MultipartParser.prototype.initWithBoundary = function(str) {
@@ -300,4 +307,8 @@ this.boundary = new Buffer(str.length+4);
   if (this.state != S.END) {
-    return new Error('MultipartParser.end(): stream ended unexpectedly');
+    return new Error('MultipartParser.end(): stream ended unexpectedly: ' + this.explain());
   }
 };
+
+MultipartParser.prototype.explain = function() {
+  return 'state = ' + MultipartParser.stateToString(this.state);
+};

package.json

 {
   "name": "formidable",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "dependencies": {},
@@ -5,0 +5,0 @@ "devDependencies": {

Readme.md

@@ -23,2 +23,11 @@ # Formidable
 
+### v1.0.5
+
+* Support filename="" in multipart parts
+* Explain unexpected end() errors in parser better
+
+### v1.0.4
+
+* Detect a good default tmp directory regardless of plattform. (#88)
+
 ### v1.0.3
@@ -25,0 +34,0 @@

test/legacy/simple/test-multipart-parser.js

@@ -43,3 +43,3 @@ var common = require('../common');
   (function testError() {
-    assert.equal(parser.end().message, 'MultipartParser.end(): stream ended unexpectedly');
+    assert.equal(parser.end().message, 'MultipartParser.end(): stream ended unexpectedly: ' + parser.explain());
   })();
@@ -46,0 +46,0 @@

No alert changes

Improved metrics

Total package byte prevSize

2884045

increased by2.93%

Number of package files

78

increased by13.04%

Lines of code

1950

increased by0.62%

Number of lines in readme file

276

increased by3.37%

No dependency changes