frete - npm Package Compare versions

Comparing version 0.2.3 to 0.2.4

frete.js

@@ -80,7 +80,14 @@ 'use strict';
 
-allOptions.forEach(function (opt) {
-    var setters = buildSetters(defaultOptions, opt);
+allOptions.forEach(function (propertyName) {
+    let setterName = getSetterName(propertyName);
+    let proto = Frete.prototype;
 
-    for (let setterName in setters) {
-        frete[setterName] = setters[setterName];
+    frete[propertyName] = frete[setterName] = function (value) {
+        defaultOptions[propertyName] = value;
+        return this;
+    };
+
+    proto[propertyName] = proto[setterName] = function (value) {
+        this.options[propertyName] = value;
+        return this;
     }
@@ -94,17 +101,7 @@ });
 
-    const self = this;
+    this.options = opts;
+    for (let key in this.options) {
+        let value = this.options[key];
 
-    self.options = opts;
-    allOptions.forEach(function (opt) {
-        var setters = buildSetters(self.options, opt);
-
-        for (let setterName in setters) {
-            self[setterName] = setters[setterName];
-        }
-    });
-
-    for (let key in self.options) {
-        let value = self.options[key];
-
-        if (!V.isFunction(self[key])) {
+        if (!V.isFunction(this[key])) {
             continue;
@@ -114,3 +111,3 @@ }
         if (V.isString(value) || V.isNumber(value) || V.isArray(value)) {
-            self[key](value);
+            this[key](value);
         }
@@ -369,4 +366,3 @@ }
 
-function buildSetters (optionsObject, propertyName) {
-    V.object(optionsObject, 'options object');
+function getSetterName (propertyName) {
     V.string(propertyName, 'property name');
@@ -391,11 +387,5 @@
 
-    var setters = {};
-    setters[propertyName] = setters[prettyNameMethod] = function (value) {
-        optionsObject[propertyName] = value;
-        return this;
-    };
-
-    return setters;
+    return prettyNameMethod;
 }
 
 module.exports = frete;

package.json

 {
   "name": "frete",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "Modulo para consumo da API de frete dos correios brasileiros.",
@@ -5,0 +5,0 @@ "main": "frete.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

69895

decreased by-0.33%

Lines of code

518

decreased by-1.33%

No dependency changes