fs-extra - npm Package Compare versions

Comparing version 7.0.0 to 7.0.1

CHANGELOG.md

		@@ -0,1 +1,8 @@
		7.0.1 / 2018-11-07
		------------------

		- Fix `removeSync()` on Windows, in some cases, it would error out with `ENOTEMPTY` ([#646](https://github.com/jprichardson/node-fs-extra/pull/646))
		- Document `mode` option for `ensureDir*()` ([#587](https://github.com/jprichardson/node-fs-extra/pull/587))
		- Don't include documentation files in npm package tarball ([#642](https://github.com/jprichardson/node-fs-extra/issues/642), [#643](https://github.com/jprichardson/node-fs-extra/pull/643))

		7.0.0 / 2018-07-16
		@@ -2,0 +9,0 @@ ------------------

lib/remove/rimraf.js

+@@ -293,20 +293,20 @@ 'use strict'
+  // We only end up here once we got ENOTEMPTY at least once, and
+  // at this point, we are guaranteed to have removed all the kids.
+  // So, we know that it won't be ENOENT or ENOTDIR or anything else.
+  // try really hard to delete stuff on windows, because it has a
+  // PROFOUNDLY annoying habit of not closing handles promptly when
+  // files are deleted, resulting in spurious ENOTEMPTY errors.
+  const retries = isWindows ? 100 : 1
+  let i = 0
+  do {
+    let threw = true
+    try {
+      const ret = options.rmdirSync(p, options)
+      threw = false
+      return ret
+    } finally {
+      if (++i < retries && threw) continue // eslint-disable-line
+  } while (true)
+  if (isWindows) {
+    // We only end up here once we got ENOTEMPTY at least once, and
+    // at this point, we are guaranteed to have removed all the kids.
+    // So, we know that it won't be ENOENT or ENOTDIR or anything else.
+    // try really hard to delete stuff on windows, because it has a
+    // PROFOUNDLY annoying habit of not closing handles promptly when
+    // files are deleted, resulting in spurious ENOTEMPTY errors.
+    const startTime = Date.now()
+    do {
+      try {
+        const ret = options.rmdirSync(p, options)
+        return ret
+      } catch (er) { }
+    } while (Date.now() - startTime < 500) // give up after 500ms
+  } else {
+    const ret = options.rmdirSync(p, options)
+    return ret
+@@ -313,0 +313,0 @@

package.json

		{
		"name": "fs-extra",
		"version": "7.0.0",
		"version": "7.0.1",
		"description": "fs-extra contains methods that aren't included in the vanilla Node.js fs package. Such as mkdir -p, cp -r, and rm -rf.",
		@@ -63,3 +63,3 @@ "engines": {
		"coveralls": "coveralls < coverage/lcov.info",
		"lint": "standard && standard-markdown",
		"lint": "standard",
		"test-find": "find ./lib/*/__tests__ -name .test.js \| xargs mocha",
		@@ -66,0 +66,0 @@ "test": "npm run lint && npm run unit",

docs/copy-sync.md

docs/copy.md

docs/emptyDir-sync.md

docs/emptyDir.md

docs/ensureDir-sync.md

docs/ensureDir.md

docs/ensureFile-sync.md

docs/ensureFile.md

docs/ensureLink-sync.md

docs/ensureLink.md

docs/ensureSymlink-sync.md

docs/ensureSymlink.md

docs/fs-read-write.md

docs/move-sync.md

docs/move.md

docs/outputFile-sync.md

docs/outputFile.md

docs/outputJson-sync.md

docs/outputJson.md

docs/pathExists-sync.md

docs/pathExists.md

docs/readJson-sync.md

docs/readJson.md

docs/remove-sync.md

docs/remove.md

docs/writeJson-sync.md

docs/writeJson.md

New alerts