gaze - npm Package Compare versions

Comparing version 0.1.3 to 0.1.4

lib/gaze.js

@@ -267,9 +267,18 @@ /*
   var opts = Object.create(this.options);
-  var once = _.once(done);
+  // TODO: Optimize this. Should kill the other func per event
+  // then unwatch files to not even bother using the method
+  var watchOne = function() { done(null, file); };
+  var watchTwo = function() { done(null, file); };
   _this._watchers[file] = fs.watch(file, opts, function(event) {
-    once(event, file);
+    if (typeof watchOne === 'function') {
+      watchTwo = null;
+      watchOne();
+    }
   });
   fs.watchFile(file, opts, function(curr, prev) {
     if (curr.mtime.getTime() !== prev.mtime.getTime()) {
-      once(null, file);
+      if (typeof watchTwo === 'function') {
+        watchOne = null;
+        watchTwo();
+      }
     }
@@ -276,0 +285,0 @@ });

package.json

 {
   "name": "gaze",
   "description": "A globbing fs.watch wrapper built from the best parts of other fine watch libs.",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "homepage": "https://github.com/shama/gaze",
@@ -6,0 +6,0 @@ "author": {

README.md

@@ -141,2 +141,3 @@ # gaze [![Build Status](https://secure.travis-ci.org/shama/gaze.png?branch=master)](http://travis-ci.org/shama/gaze)
 ## Release History
+* 0.1.4 - Really fix the race condition with 2 watches
 * 0.1.3 - Fix race condition with 2 watches
@@ -143,0 +144,0 @@ * 0.1.2 - Read triggering changed event fix

test/watch_test.js

@@ -125,3 +125,22 @@ 'use strict';
     });
+  },
+  emitTwice: function(test) {
+    test.expect(2);
+    var times = 0;
+    gaze('**/*', function(err, watcher) {
+      watcher.on('all', function(status, filepath) {
+        test.equal(status, 'changed');
+        times++;
+        setTimeout(function() {
+          if (times < 2) {
+            fs.writeFileSync(path.resolve(__dirname, 'fixtures', 'sub', 'one.js'), 'var one = true;');
+          } else {
+            watcher.close();
+            test.done();
+          }
+        }, 1000);
+      });
+      fs.writeFileSync(path.resolve(__dirname, 'fixtures', 'sub', 'one.js'), 'var one = true;');
+    });
   }
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25846

increased by4.01%

Lines of code

618

increased by4.75%

Number of lines in readme file

150

increased by0.67%

No dependency changes