generic-pool - npm Package Compare versions

Comparing version 3.0.0 to 3.0.1

CHANGELOG.md

 # Change Log
 
+## [3.0.1] - November 1 2016
+- Passthrough Pool's promise impl to deferreds so they are used internally and exposed correctly on pool.acquire (@eide)
+
 ## [3.0.0] - October 30 2016
@@ -122,7 +125,6 @@ - This is pretty big and the migration guide in the README has more detailed set of changes!
 
-<<<<<<< HEAD
-
 =======
-[unreleased]: https://github.com/coopernurse/node-pool/compare/v3.0.0...HEAD
-[3.0.0]: https://github.com/coopernurse/node-pool/compare/v2.4.1...v3.0.0
+[unreleased]: https://github.com/coopernurse/node-pool/compare/v3.0.1...HEAD
+[3.0.1]: https://github.com/coopernurse/node-pool/compare/v3.0.0...v3.0.1
+[3.0.0]: https://github.com/coopernurse/node-pool/compare/v2.4.3...v3.0.0
 [2.4.3]: https://github.com/coopernurse/node-pool/compare/v2.4.2...v2.4.3
@@ -129,0 +131,0 @@ [2.4.2]: https://github.com/coopernurse/node-pool/compare/v2.4.1...v2.4.2

lib/Deferred.js

@@ -9,3 +9,3 @@ 'use strict'
 
-  constructor () {
+  constructor (Promise) {
     this._state = Deferred.PENDING
@@ -12,0 +12,0 @@ this._resolve = undefined

lib/Pool.js

@@ -261,3 +261,3 @@ 'use strict'
     }
-    const loan = new ResourceLoan(pooledResource)
+    const loan = new ResourceLoan(pooledResource, this._Promise)
     this._resourceLoans.set(pooledResource.obj, loan)
@@ -403,3 +403,3 @@ pooledResource.allocate()
 
-    const resourceRequest = new ResourceRequest(this._config.acquireTimeoutMillis)
+    const resourceRequest = new ResourceRequest(this._config.acquireTimeoutMillis, this._Promise)
     this._waitingClientsQueue.enqueue(resourceRequest, priority)
@@ -406,0 +406,0 @@ this._dispense()

lib/ResourceLoan.js

@@ -16,4 +16,4 @@ 'use strict'
    */
-  constructor (pooledResource) {
-    super()
+  constructor (pooledResource, Promise) {
+    super(Promise)
     this._creationTimestamp = Date.now()
@@ -20,0 +20,0 @@ this.pooledResource = pooledResource

lib/ResourceRequest.js

@@ -23,4 +23,4 @@ 'use strict'
    */
-  constructor (ttl) {
-    super()
+  constructor (ttl, Promise) {
+    super(Promise)
     this._creationTimestamp = Date.now()
@@ -27,0 +27,0 @@ this._timeout = null

package.json

 {
   "name": "generic-pool",
   "description": "Generic resource pooling for Node.JS",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "author": "James Cooper <[e-mail]>",
@@ -6,0 +6,0 @@ "contributors": [

test/resource-request-test.js

@@ -6,3 +6,3 @@ var tap = require('tap')
   var create = function () {
-    var request = new ResourceRequest() // eslint-disable-line no-unused-vars
+    var request = new ResourceRequest(undefined, Promise) // eslint-disable-line no-unused-vars
   }
@@ -21,3 +21,3 @@ t.doesNotThrow(create)
   }
-  var request = new ResourceRequest(10) // eslint-disable-line no-unused-vars
+  var request = new ResourceRequest(10, Promise) // eslint-disable-line no-unused-vars
 
@@ -36,3 +36,3 @@ request.promise.then(resolve, reject)
   }
-  var request = new ResourceRequest()
+  var request = new ResourceRequest(undefined, Promise)
   request.promise.then(resolve, reject)
@@ -46,3 +46,3 @@ request.resolve(resource)
   }
-  var request = new ResourceRequest(10)
+  var request = new ResourceRequest(10, Promise)
   request.promise.then(undefined, reject)
@@ -56,3 +56,3 @@ request.removeTimeout()
 tap.test('does nothing if resolved more than once', function (t) {
-  var request = new ResourceRequest()
+  var request = new ResourceRequest(undefined, Promise)
   t.doesNotThrow(function () {
@@ -59,0 +59,0 @@ request.resolve({})

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

83658

increased by0.43%

No dependency changes