github-url-to-object - npm Package Compare versions

Comparing version 4.0.5 to 4.0.6

dist/commonjs.js

@@ -50,3 +50,3 @@ 'use strict'
 
-    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[\w-_\.\/]+)?(\/blob\/[\w-_\.\/]+)?/)
+    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[\%\w-_\.\/]+)?(\/blob\/[\%\w-_\.\/]+)?/)
     // ([\w-_\.]+)
@@ -63,5 +63,7 @@ if (!parts) { return null }
     } else if (parts[3]) {
-      obj.branch = parts[3].replace(/^\/tree\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      var branchMatch = parts[3].replace(/^\/tree\//, '').match(/[\%\w-_.]*\/?[\%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else if (parts[4]) {
-      obj.branch = parts[4].replace(/^\/blob\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      var branchMatch = parts[4].replace(/^\/blob\//, '').match(/[\%\w-_.]*\/?[\%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else {
@@ -68,0 +70,0 @@ obj.branch = 'master'

dist/gh.js

@@ -51,3 +51,3 @@ (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.gh = f()}})(function(){var define,module,exports;return (function(){function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a){ return a(o,!0); }if(i){ return i(o,!0); }var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++){ s(r[o]); }return s}return e})()({1:[function(require,module,exports){
 
-    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[\w-_\.\/]+)?(\/blob\/[\w-_\.\/]+)?/)
+    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[\%\w-_\.\/]+)?(\/blob\/[\%\w-_\.\/]+)?/)
     // ([\w-_\.]+)
@@ -64,5 +64,7 @@ if (!parts) { return null }
     } else if (parts[3]) {
-      obj.branch = parts[3].replace(/^\/tree\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      var branchMatch = parts[3].replace(/^\/tree\//, '').match(/[\%\w-_.]*\/?[\%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else if (parts[4]) {
-      obj.branch = parts[4].replace(/^\/blob\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      var branchMatch = parts[4].replace(/^\/blob\//, '').match(/[\%\w-_.]*\/?[\%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else {
@@ -69,0 +71,0 @@ obj.branch = 'master'

index.js

@@ -48,3 +48,3 @@ 'use strict'
 
-    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[\w-_\.\/]+)?(\/blob\/[\w-_\.\/]+)?/)
+    var parts = pathname.match(/^\/([\w-_]+)\/([\w-_\.]+)(\/tree\/[%\w-_\.\/]+)?(\/blob\/[%\w-_\.\/]+)?/)
     // ([\w-_\.]+)
@@ -61,5 +61,7 @@ if (!parts) return null
     } else if (parts[3]) {
-      obj.branch = parts[3].replace(/^\/tree\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      const branchMatch = parts[3].replace(/^\/tree\//, '').match(/[%\w-_.]*\/?[%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else if (parts[4]) {
-      obj.branch = parts[4].replace(/^\/blob\//, '').match(/[\w-_.]+\/{0,1}[\w-_]+/)[0]
+      const branchMatch = parts[4].replace(/^\/blob\//, '').match(/[%\w-_.]*\/?[%\w-_]+/)
+      obj.branch = branchMatch && branchMatch[0]
     } else {
@@ -66,0 +68,0 @@ obj.branch = 'master'

package.json

 {
   "name": "github-url-to-object",
-  "version": "4.0.5",
+  "version": "4.0.6",
   "description": "Extract user, repo, and other interesting properties from GitHub URLs",
@@ -5,0 +5,0 @@ "main": "dist/commonjs.js",

test/index.js

@@ -208,2 +208,22 @@ /* globals before, describe, it */
 
+    it('resolves URLS for branches with single character names', function () {
+      var obj = gh('https://github.com/zeke/outlet/tree/q')
+      assert.strictEqual(obj.branch, 'q')
+    })
+
+    it('resolves URLS for branches with single digit names', function () {
+      var obj = gh('https://github.com/zeke/outlet/tree/0')
+      assert.strictEqual(obj.branch, '0')
+    })
+
+    it('resolves URLS for branches containing special characters', function () {
+      var obj = gh('https://github.com/zeke/outlet/tree/%3D%40')
+      assert.strictEqual(obj.branch, '%3D%40')
+    })
+
+    it('resolves URLS for branches containing special characters following after normal one', function () {
+      var obj = gh('https://github.com/zeke/outlet/tree/v%3D%40')
+      assert.strictEqual(obj.branch, 'v%3D%40')
+    })
+
     it('resolves blob-style URLS for branches other than master', function () {
@@ -210,0 +230,0 @@ var obj = gh('https://github.com/zeke/ord/blob/new-style/.gitignore')

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

30162

increased by3.9%

Lines of code

587

increased by3.89%

No dependency changes