github - npm Package Compare versions

Comparing version 8.1.0 to 8.1.1

CHANGELOG.md

 # CHANGELOG
 
+## 8.1.1
+
+Bug fixes:
+  * Typescript: only set generated Array body properties to string[].
+
 ## 8.1.0
@@ -4,0 +9,0 @@

lib/generate.js

@@ -189,4 +189,4 @@ #!/usr/bin/env node
 
-    var apidocsPath = Path.join(__dirname, "/../doc", "apidoc.js");
-    fs.writeFileSync(apidocsPath, apidocs);
+    // var apidocsPath = Path.join(__dirname, "/../doc", "apidoc.js");
+    // fs.writeFileSync(apidocsPath, apidocs);
 
@@ -193,0 +193,0 @@ Object.keys(sections).forEach(function(section) {

lib/generateTypes.js

@@ -35,3 +35,2 @@ #!/usr/bin/env node
         case "assignees":
-        case "body":
         case "repositories":
@@ -47,6 +46,11 @@ case "repo_names":
         case "comments":
-            return "string[]";
-        default:
-            return type;
+        case "labels":
+        case "teams":
+        case "users":
+        case "emails":
+            if (type === "Array") {
+                return "string[]";
+            }
     }
+    return type;
 }
@@ -53,0 +57,0 @@

package.json

 {
   "name": "github",
-  "version": "8.1.0",
+  "version": "8.1.1",
   "description": "NodeJS wrapper for the GitHub API",
@@ -53,3 +53,3 @@ "author": "Mike de Boer <[e-mail]>",
     "name": "node-github",
-    "version": "8.1.0",
+    "version": "8.1.1",
     "template": {
@@ -56,0 +56,0 @@ "withCompare": true

README.md

@@ -166,2 +166,7 @@ **NOTE: The `node-github` npm package is deprecated. You want the `github` npm package (see Installation).**
 
+## Promises
+
+For using bluebird, see [here](https://github.com/mikedeboer/node-github/blob/master/examples/testPromise.js).  
+For using Q, see [here](https://github.com/mikedeboer/node-github/blob/master/examples/testPromiseQ.js).
+
 ## Tests
@@ -168,0 +173,0 @@

test/enterpriseTest.js

@@ -120,3 +120,3 @@ /*
                 id: "String",
-                body: "Json"
+                hook: "Json"
             },
@@ -123,0 +123,0 @@ function(err, res) {

test/issuesTest.js

@@ -50,3 +50,3 @@ /*
                 number: "Number",
-                body: "Array"
+                labels: "Array"
             },
@@ -85,3 +85,3 @@ function(err, res) {
                 milestone: "Number",
-                labels: "Json",
+                labels: "Array",
                 assignees: "Array"
@@ -203,3 +203,3 @@ },
                 milestone: "Number",
-                labels: "Json",
+                labels: "Array",
                 assignees: "Array"
@@ -593,3 +593,3 @@ },
                 number: "Number",
-                body: "Json"
+                assignees: "Array"
             },
@@ -626,3 +626,3 @@ function(err, res) {
                 number: "Number",
-                body: "Array"
+                labels: "Array"
             },
@@ -629,0 +629,0 @@ function(err, res) {

test/pullRequestsTest.js

@@ -184,3 +184,3 @@ /*
 
-    it("should successfully execute GET /repos/:owner/:repo/pulls/:number/reviews/:id/dismissals (dismissReview)",  function(next) {
+    it("should successfully execute PUT /repos/:owner/:repo/pulls/:number/reviews/:id/dismissals (dismissReview)",  function(next) {
         client.pullRequests.dismissReview(
@@ -187,0 +187,0 @@ {

test/reposTest.js

@@ -50,3 +50,3 @@ /*
                 branch: "String",
-                body: "Array"
+                contexts: "Array"
             },
@@ -67,3 +67,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                teams: "Array"
             },
@@ -84,3 +84,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                users: "Array"
             },
@@ -1624,3 +1624,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                contexts: "Array"
             },
@@ -1656,3 +1656,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                teams: "Array"
             },
@@ -1673,3 +1673,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                users: "Array"
             },
@@ -1690,3 +1690,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                contexts: "Array"
             },
@@ -1707,3 +1707,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                teams: "Array"
             },
@@ -1724,3 +1724,3 @@ function(err, res) {
                 branch: "String",
-                body: "Array"
+                users: "Array"
             },
@@ -1727,0 +1727,0 @@ function(err, res) {

test/usersTest.js

@@ -44,3 +44,3 @@ /*
             {
-                body: "Array"
+                emails: "Array"
             },
@@ -125,3 +125,3 @@ function(err, res) {
             {
-                body: "Array"
+                emails: "Array"
             },
@@ -128,0 +128,0 @@ function(err, res) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1693260

increased by0.33%

Lines of code

45656

increased by0.61%

Number of lines in readme file

229

increased by2.23%

No dependency changes