goban - npm Package Compare versions

Comparing version 0.5.1 to 0.5.2

lib/GoMath.d.ts

@@ -27,3 +27,3 @@ import { GoStoneGroup } from "./GoStoneGroup";
     static prettyCoords(x: number, y: number, board_height: number): string;
-    static decodeMoves(move_obj: AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width?: number, height?: number): Array<JGOFMove>;
+    static decodeMoves(move_obj: AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width: number, height: number): Array<JGOFMove>;
     private static char2num;
@@ -30,0 +30,0 @@ private static pretty_char2num;

lib/SFXManager.d.ts

@@ -8,3 +8,3 @@ export declare class SFXManager {
     private play_promise_future_state;
-    volume_override?: number;
+    volume_override?: number | null;
     constructor();
@@ -11,0 +11,0 @@ enable(): void;

node/GoMath.d.ts

@@ -27,3 +27,3 @@ import { GoStoneGroup } from "./GoStoneGroup";
     static prettyCoords(x: number, y: number, board_height: number): string;
-    static decodeMoves(move_obj: AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width?: number, height?: number): Array<JGOFMove>;
+    static decodeMoves(move_obj: AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width: number, height: number): Array<JGOFMove>;
     private static char2num;
@@ -30,0 +30,0 @@ private static pretty_char2num;

package.json

 {
     "name": "goban",
-    "version": "0.5.1",
+    "version": "0.5.2",
     "description": "",
@@ -45,3 +45,3 @@ "main": "lib/goban.js",
         "ts-loader": "^6.2.1",
-        "tslint": "^5.20.0",
+        "tslint": "^5.20.1",
         "typedoc": "^0.15.0",
@@ -48,0 +48,0 @@ "typescript": "^3.7.2",

src/GoMath.ts

@@ -178,3 +178,3 @@ /*
     }
-    public static decodeMoves(move_obj:AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width?:number, height?:number): Array<JGOFMove> {
+    public static decodeMoves(move_obj:AdHocPackedMove | string | Array<AdHocPackedMove> | [object] | Array<JGOFMove> | JGOFMove, width:number, height:number): Array<JGOFMove> {
         let ret: Array<Move> = [];
@@ -181,0 +181,0 @@

src/SFXManager.ts

@@ -26,3 +26,3 @@ /*
     private play_promise_future_state: {[id:string]: string} = {};
-    public volume_override?:number;
+    public volume_override?:number | null;
 
@@ -39,3 +39,3 @@ constructor() {
     public sync():void {
-        if (!this.enabled && !this.volume_override) { return; }
+        if (!this.enabled && this.volume_override === 0) { return; }
 
@@ -63,9 +63,6 @@ if (GobanCore.getSoundEnabled() || this.volume_override) {
     public play(name:string, play_even_if_window_doesnt_have_focus?:boolean):void {
-        if (!this.enabled && !this.volume_override) { return; }
+        if (!this.enabled && this.volume_override === 0) { return; }
         this.sync();
 
         if (GobanCore.getSoundEnabled() || this.volume_override) {
-            if (!this.volume_override) {
-                return;
-            }
             try {
@@ -138,3 +135,6 @@ let volume = GobanCore.getSoundVolume();
     private addAudio(name:string, pathname:string):void {
-        if (!this.enabled && !this.volume_override) { return; }
+        if (!this.enabled && this.volume_override === 0) { return; }
+        if (!GobanCore.getCDNReleaseBase()) {
+            return;
+        }
 
@@ -141,0 +141,0 @@ if (pathname in this.loaded) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

6125125

decreased by-0.06%

Lines of code

43059

decreased by-0.09%

No dependency changes