google-gax - npm Package Compare versions

Comparing version 4.3.2 to 4.3.3

build/src/createApiCall.js

@@ -84,8 +84,12 @@ "use strict";
             const retry = thisSettings.retry;
-            if (streaming &&
-                retry &&
-                retry.retryCodes.length > 0 &&
-                retry.shouldRetryFn) {
-                (0, warnings_1.warn)('either_retrycodes_or_shouldretryfn', 'Only one of retryCodes or shouldRetryFn may be defined. Ignoring retryCodes.');
-                retry.retryCodes = [];
+            if (streaming && retry) {
+                if (retry.retryCodes.length > 0 && retry.shouldRetryFn) {
+                    (0, warnings_1.warn)('either_retrycodes_or_shouldretryfn', 'Only one of retryCodes or shouldRetryFn may be defined. Ignoring retryCodes.');
+                    retry.retryCodes = [];
+                }
+                if (!currentApiCaller.descriptor
+                    .gaxStreamingRetries &&
+                    retry.getResumptionRequestFn) {
+                    throw new Error('getResumptionRequestFn can only be used when gaxStreamingRetries is set to true.');
+                }
             }
@@ -92,0 +96,0 @@ if (!streaming && retry) {

build/src/streamingCalls/streaming.js

@@ -245,4 +245,5 @@ "use strict";
     defaultShouldRetry(error, retry) {
-        if (retry.retryCodes.length > 0 &&
-            retry.retryCodes.indexOf(error.code) < 0) {
+        if ((retry.retryCodes.length > 0 &&
+            retry.retryCodes.indexOf(error.code) < 0) ||
+            retry.retryCodes.length === 0) {
             return false;
@@ -249,0 +250,0 @@ }

package.json

 {
   "name": "google-gax",
-  "version": "4.3.2",
+  "version": "4.3.3",
   "description": "Google API Extensions",
@@ -13,3 +13,3 @@ "main": "build/src/index.js",
   "dependencies": {
-    "@grpc/grpc-js": "~1.10.0",
+    "@grpc/grpc-js": "~1.10.3",
     "@grpc/proto-loader": "^0.7.0",
@@ -77,3 +77,2 @@ "@types/long": "^4.0.0",
     "compile-http-protos": "pbjs -t static-module -r http_proto --keep-case google/api/http.proto -p ./protos > protos/http.js && pbts protos/http.js -o protos/http.d.ts",
-    "compile-showcase-proto": "pbjs -t json google/showcase/v1beta1/echo.proto google/showcase/v1beta1/identity.proto google/showcase/v1beta1/messaging.proto google/showcase/v1beta1/testing.proto -p ./protos > test/fixtures/google-gax-packaging-test-app/protos/protos.json && pbjs -t static-module -r showcase_protos google/showcase/v1beta1/echo.proto google/showcase/v1beta1/identity.proto google/showcase/v1beta1/messaging.proto google/showcase/v1beta1/testing.proto -p ./protos > test/fixtures/google-gax-packaging-test-app/protos/protos.js && pbts test/fixtures/google-gax-packaging-test-app/protos/protos.js -o test/fixtures/google-gax-packaging-test-app/protos/protos.d.ts",
     "fix": "gts fix",
@@ -80,0 +79,0 @@ "prepare": "npm run compile && cd ../tools && npm i && npm run compile && cd ../gax && pwd && node ../tools/build/src/prepublish.js . && mkdirp build/protos && cp -r protos/* build/protos/ && npm run minify-proto-json",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3285405

increased by0.01%

Lines of code

27338

increased by0.02%

Dependency changes

• Updated@grpc/grpc-js@~1.10.3