googleapis-common - npm Package Compare versions

Comparing version 3.1.0 to 3.1.1

build/src/apirequest.d.ts

@@ -0,1 +1,16 @@
+/**
+ * Copyright 2016 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 import { GaxiosPromise } from 'gaxios';
@@ -2,0 +17,0 @@ import { APIRequestParams, BodyResponseCallback } from './api';

build/src/apirequest.js

 "use strict";
-// Copyright 2014-2016, Google, Inc.
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//    http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+/**
+ * Copyright 2016 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -69,3 +72,3 @@ const google_auth_library_1 = require("google-auth-library");
      * to have an actual named parameter required which is also named `resource`.
-     * This mean that users would have to use `resource_` in those cases, which
+     * This meant that users would have to use `resource_` in those cases, which
      * pretty much nobody figures out on their own. The request body is now
@@ -80,4 +83,8 @@ * documented as being in the `requestBody` property, but we also need to keep
      */
-    const resource = params.requestBody ? params.requestBody : params.resource;
-    if (!params.requestBody && params.resource) {
+    let resource = params.requestBody;
+    if (!params.requestBody &&
+        params.resource &&
+        (!parameters.requiredParams.includes('resource') ||
+            typeof params.resource !== 'string')) {
+        resource = params.resource;
         delete params.resource;
@@ -271,6 +278,5 @@ }
     if (!isbrowser_1.isBrowser()) {
-        const nodeVersion = process.version.replace(/^v/, '');
-        headers['x-goog-api-client'] = `gdcl/${pkg.version} gl-node/${nodeVersion}`;
+        headers['x-goog-api-client'] = `gdcl/${pkg.version} gl-node/${process.versions.node}`;
     }
 }
 //# sourceMappingURL=apirequest.js.map

CHANGELOG.md

@@ -7,2 +7,9 @@ # Changelog
 
+### [3.1.1](https://www.github.com/googleapis/nodejs-googleapis-common/compare/v3.1.0...v3.1.1) (2019-10-08)
+
+
+### Bug Fixes
+
+* allow for resource url parameter ([#178](https://www.github.com/googleapis/nodejs-googleapis-common/issues/178)) ([a3ddd5b](https://www.github.com/googleapis/nodejs-googleapis-common/commit/a3ddd5b))
+
 ## [3.1.0](https://www.github.com/googleapis/nodejs-googleapis-common/compare/v3.0.0...v3.1.0) (2019-08-12)
@@ -9,0 +16,0 @@

package.json

 {
   "name": "googleapis-common",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "A common tooling library used by the googleapis npm module. You probably don't want to use this directly.",
@@ -53,3 +53,3 @@ "repository": "googleapis/nodejs-googleapis-common",
     "karma-chrome-launcher": "^3.0.0",
-    "karma-coverage": "^1.1.2",
+    "karma-coverage": "^2.0.0",
     "karma-firefox-launcher": "^1.1.0",
@@ -70,3 +70,3 @@ "karma-mocha": "^1.3.0",
     "ts-loader": "^6.0.4",
-    "typescript": "~3.5.2",
+    "typescript": "~3.6.0",
     "webpack": "^4.35.0",
@@ -73,0 +73,0 @@ "webpack-cli": "^3.3.5"

README.md

@@ -86,3 +86,1 @@ [//]: # "This README.md file is auto-generated, all changes to this file will be lost."
 [auth]: https://cloud.google.com/docs/authentication/getting-started
-
-<a name="reference"></a>

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

66408

increased by1.48%

Lines of code

1039

increased by2.06%

Worsened metrics

Number of lines in readme file

86

decreased by-2.27%

No dependency changes