growl - npm Package Compare versions

Comparing version 1.6.0 to 1.6.1

History.md

 
+1.6.1 / 2012-09-25 
+==================
+
+  * restore compatibility with node < 0.8 [fgnass]
+
 1.6.0 / 2012-09-06 
@@ -3,0 +8,0 @@ ==================

lib/growl.js

@@ -8,5 +8,7 @@ // Growl - Copyright TJ Holowaychuk <[e-mail]> (MIT Licensed)
 var exec = require('child_process').exec
-  , exists = require('fs').existsSync
+  , fs = require('fs')
   , path = require('path')
+  , exists = fs.existsSync || path.existsSync
   , os = require('os')
+  , quote = JSON.stringify
   , cmd;
@@ -169,3 +171,3 @@
       case 'Windows':
-        args.push(cmd.icon + '"' + image.replace(/\\/g, "\\\\") + '"');
+        args.push(cmd.icon + quote(image));
         break;
@@ -195,15 +197,15 @@ }
       args.push(cmd.msg);
-      args.push('"' + msg + '"');
-      if (options.title) args.push('"' + options.title + '"');
+      args.push(quote(msg));
+      if (options.title) args.push(quote(options.title));
       break;
     case 'Darwin-NotificationCenter':
       args.push(cmd.msg);
-      args.push('"' + msg + '"');
+      args.push(quote(msg));
       if (options.title) {
         args.push(cmd.title);
-        args.push('"' + options.title + '"');
+        args.push(quote(options.title));
       }
       if (options.subtitle) {
         args.push(cmd.subtitle);
-        args.push('"' + options.subtitle + '"');
+        args.push(quote(options.title));
       }
@@ -213,17 +215,17 @@ break;
       args.push(cmd.msg);
-      args.push('"' + msg + '"');
-      if (options.title) args.push('"' + options.title + '"');
+      args.push(quote(msg));
+      if (options.title) args.push(quote(options.title));
       break;
     case 'Linux':
       if (options.title) {
-        args.push("'" + options.title + "'");
+        args.push(quote(options.title));
         args.push(cmd.msg);
-        args.push("'" + msg + "'");
+        args.push(quote(msg));
       } else {
-        args.push("'" + msg + "'");
+        args.push(quote(msg));
       }
       break;
     case 'Windows':
-      args.push('"' + msg + '"');
-      if (options.title) args.push(cmd.title + '"' + options.title + '"');
+      args.push(quote(msg));
+      if (options.title) args.push(cmd.title + quote(options.title));
       break;
@@ -230,0 +232,0 @@ }

package.json

 {
   "name": "growl",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "Growl unobtrusive notifications",
@@ -5,0 +5,0 @@ "author": "TJ Holowaychuk <[e-mail]>",

test.js

@@ -18,1 +18,4 @@
 growl('Show pdf filesystem icon', { title: 'Use show()', image: 'article.pdf' })
+growl('here \' are \n some \\ characters that " need escaping', {}, function(error, stdout, stderr) {
+  if (error !== null) throw new Error('escaping failed:\n' + stdout + stderr);
+})

Fixed alerts

Non-existent author

Supply chain risk

The package was published by an npm account that no longer exists.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

10797

increased by2.3%

Lines of code

232

increased by2.2%

Number of high supply chain risk alerts

0

decreased by-100%

No dependency changes