grpc-server-js - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

lib/handler.js

@@ -29,12 +29,5 @@ 'use strict';
   _read (size) {
-    if (this.finished) {
-      this.push(null);
-    }
+    this.call.resume();
   }
 
-  _terminate () {
-    this.finished = true;
-    this.on('data', noop);
-  }
-
   deserialize (input) {
@@ -122,9 +115,4 @@ if (input === null || input === undefined) {
   ServerReadableStream.prototype.deserialize;
-ServerDuplexStream.prototype._terminate =
-  ServerReadableStream.prototype._terminate;
 
 
-function noop () {}
-
-
 function sendMetadata (responseMetadata) {
@@ -156,12 +144,10 @@ return this[kCall].sendMetadata(responseMetadata);
 function setUpReadable (stream) {
-  stream.finished = false;
+  const decoder = new StreamDecoder();
 
   stream.once('cancelled', () => {
-    stream._terminate();
+    stream.destroy();
   });
 
-  stream.decoder = new StreamDecoder();
-
   stream.call.on('data', async (data) => {
-    const message = stream.decoder.write(data);
+    const message = decoder.write(data);
 
@@ -175,3 +161,5 @@ if (message === null) {
 
-      stream.push(deserialized);
+      if (!stream.push(deserialized)) {
+        stream.call.pause();
+      }
     } catch (err) {
@@ -178,0 +166,0 @@ err.code = Status.INTERNAL;

lib/server.js

@@ -278,3 +278,3 @@ 'use strict';
   function respond (err, value, trailer, flags) {
-    stream._terminate();
+    stream.destroy();
     call.sendUnaryMessage(err, value, trailer, flags);
@@ -281,0 +281,0 @@ }

package.json

 {
   "name": "grpc-server-js",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Pure JavaScript gRPC Server",
@@ -5,0 +5,0 @@ "author": "Colin J. Ihrig <[e-mail]> (http://www.cjihrig.com/)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

35568

decreased by-0.6%

Lines of code

987

decreased by-0.8%

No dependency changes