grunt-selenium-server - npm Package Compare versions

Comparing version 0.0.1 to 0.1.0

package.json

 {
   "name": "grunt-selenium-server",
-  "version": "0.0.1",
+  "version": "0.1.0",
   "description": "Grunt task to start/stop a local Selenium standalon server.",
@@ -5,0 +5,0 @@ "main": "Gruntfile.js",

tasks/selenium_server.js

@@ -89,9 +89,39 @@
     // Spawn server process.
+    grunt.log.ok('Using (roughly) command: java ' + args.join(' '));
     var spawn = require('child_process').spawn;
     childProcesses[target] = spawn('java', args);
 
+    grunt.event.emit('selenium.start', target, childProcesses[target]);
+
     var pid = childProcesses[target].pid;
     grunt.log.ok('Boom, got it. pid is ' + pid + ' in case you give a shit.');
 
-    cb(null);
+    var complete = false;
+
+    childProcesses[target].stdout.on('data', function(data) {
+      if (data.toString().match(/Started SocketListener on .+:\d+/)) {
+        if (complete) return;
+        grunt.log.ok('Selenium server SocketListener started.');
+
+        // Wait a tiny bit more time just because it's java and I'm worried.
+        setTimeout(function(){
+          complete = true;
+          cb(null);
+        }, 2000);
+      }
+    });
+
+    childProcesses[target].stderr.on('data', function(data) {
+      grunt.log.error(data.toString());
+    });
+
+    // Timeout case
+    setTimeout(function() {
+      if (!complete) {
+        complete = true;
+        // Try to clean up better after ourselves
+        childProcesses[target].kill('SIGTERM');
+        cb(new Error('Timeout waiting for selenium to start.'));
+      }
+    }, 30000);
   }
@@ -108,3 +138,3 @@
     var options = this.options({
-      downloadUrl: 'https://selenium.googlecode.com/files/selenium-server-standalone-2.37.0.jar',
+      downloadUrl: 'https://selenium.googlecode.com/files/selenium-server-standalone-2.42.2.jar',
       downloadLocation: '/tmp',
@@ -152,2 +182,1 @@ serverOptions: {}
 };
-

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6278

increased by18.19%

Lines of code

176

increased by16.56%

Worsened metrics

Number of medium supply chain risk alerts

2

increased by100%

No dependency changes