grunt-selenium-server - npm Package Compare versions

Comparing version 0.1.6 to 0.1.7

package.json

 {
   "name": "grunt-selenium-server",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "Grunt task to start/stop a local Selenium standalon server.",
@@ -5,0 +5,0 @@ "main": "Gruntfile.js",

tasks/selenium_server.js

@@ -44,2 +44,10 @@ var fs = require('fs');
 
+    // When the writeStream.end() resolves it will trigger a finish event.
+    // We have to wait for this before we know everything has been flushed to the filesystem. 
+    // https://nodejs.org/api/stream.html#stream_writable_end_chunk_encoding_callback
+    writeStream.on('finish', function(){
+      grunt.log.ok('done.');
+      cb(destination, null);
+    });
+
     // Start downloading and showing progress.
@@ -72,7 +80,6 @@ request(options.downloadUrl).on('response', function (res) {
 
-      // Close file and holla back.
+      // Tell the write stream that we are done calling write.
+      // The writeStream will emit a 'finish' event when everything has been written to the filesystem.
       res.on('end', function () {
         writeStream.end();
-        grunt.log.ok('done.');
-        cb(destination, null);
       });
@@ -122,3 +129,3 @@
     var pid = childProcesses[target].pid;
-    grunt.log.ok('Boom, got it. pid is ' + pid + ' in case you give a shit.');
+    grunt.log.ok('Boom, got it. pid is ' + pid + ' in case you care.');
 
@@ -125,0 +132,0 @@ var complete = false;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11851

increased by3.73%

Lines of code

242

increased by2.54%

No dependency changes