gulp-eslint - npm Package Compare versions

Comparing version 4.0.2 to 5.0.0

CHANGELOG.md

 # Changelog
 
+## 5.0.0
+
+* Bump `eslint` dependency to ^5.0.0 <https://eslint.org/blog/2018/06/eslint-v5.0.0-released>
+* Use destructuring assignment to simplify the code
+
 ## 4.0.2
@@ -4,0 +9,0 @@

index.js

 'use strict';
 
 const PluginError = require('plugin-error');
-const CLIEngine = require('eslint').CLIEngine;
-const util = require('./util');
-const path = require('path');
+const {CLIEngine} = require('eslint');
+const {
+	createIgnoreResult,
+	filterResult,
+	firstResultMessage,
+	handleCallback,
+	isErrorMessage,
+	migrateOptions,
+	resolveFormatter,
+	resolveWritable,
+	transform,
+	tryResultAction,
+	writeResults
+} = require('./util');
+const {relative} = require('path');
 
@@ -15,7 +27,7 @@ /**
 function gulpEslint(options) {
-	options = util.migrateOptions(options) || {};
+	options = migrateOptions(options) || {};
 	const linter = new CLIEngine(options);
 
-	return util.transform((file, enc, cb) => {
-		const filePath = path.relative(process.cwd(), file.path);
+	return transform((file, enc, cb) => {
+		const filePath = relative(process.cwd(), file.path);
 
@@ -42,3 +54,3 @@ if (file.isNull()) {
 				// Warn that gulp.src is needlessly reading files that ESLint ignores
-				file.eslint = util.createIgnoreResult(file);
+				file.eslint = createIgnoreResult(file);
 			}
@@ -62,3 +74,3 @@ cb(null, file);
 			// ignore warnings
-			file.eslint =  util.filterResult(result, options.quiet);
+			file.eslint =  filterResult(result, options.quiet);
 		} else {
@@ -88,5 +100,5 @@ file.eslint = result;
 
-	return util.transform((file, enc, done) => {
+	return transform((file, enc, done) => {
 		if (file.eslint) {
-			util.tryResultAction(action, file.eslint, util.handleCallback(done, file));
+			tryResultAction(action, file.eslint, handleCallback(done, file));
 		} else {
@@ -113,3 +125,3 @@ done(null, file);
 
-	return util.transform((file, enc, done) => {
+	return transform((file, enc, done) => {
 		if (file.eslint) {
@@ -124,3 +136,3 @@ results.push(file.eslint);
 	}, done => {
-		util.tryResultAction(action, results, util.handleCallback(done));
+		tryResultAction(action, results, handleCallback(done));
 	});
@@ -136,3 +148,3 @@ };
 	return gulpEslint.result(result => {
-		const error = util.firstResultMessage(result, util.isErrorMessage);
+		const error = firstResultMessage(result, isErrorMessage);
 		if (!error) {
@@ -178,6 +190,6 @@ return;
 gulpEslint.formatEach = (formatter, writable) => {
-	formatter = util.resolveFormatter(formatter);
-	writable = util.resolveWritable(writable);
+	formatter = resolveFormatter(formatter);
+	writable = resolveWritable(writable);
 
-	return gulpEslint.result(result => util.writeResults([result], formatter, writable));
+	return gulpEslint.result(result => writeResults([result], formatter, writable));
 };
@@ -193,4 +205,4 @@
 gulpEslint.format = (formatter, writable) => {
-	formatter = util.resolveFormatter(formatter);
-	writable = util.resolveWritable(writable);
+	formatter = resolveFormatter(formatter);
+	writable = resolveWritable(writable);
 
@@ -200,3 +212,3 @@ return gulpEslint.results(results => {
 		if (results.length) {
-			util.writeResults(results, formatter, writable);
+			writeResults(results, formatter, writable);
 		}
@@ -203,0 +215,0 @@ });

package.json

 {
 	"name": "gulp-eslint",
-	"version": "4.0.2",
+	"version": "5.0.0",
 	"description": "A gulp plugin for processing files with ESLint",
@@ -15,3 +15,3 @@ "repository": "adametry/gulp-eslint",
 	"scripts": {
-		"pretest": "gulp test",
+		"pretest": "gulp",
 		"test": "mocha",
@@ -44,16 +44,16 @@ "gulp": "gulp",
 	"dependencies": {
-		"eslint": "^4.0.0",
+		"eslint": "^5.0.1",
 		"fancy-log": "^1.3.2",
-		"plugin-error": "^1.0.0"
+		"plugin-error": "^1.0.1"
 	},
 	"devDependencies": {
 		"@shinnn/eslint-config-node": "^5.0.0",
-		"babel-eslint": "^8.0.1",
+		"babel-eslint": "^8.2.5",
 		"from2-string": "^1.1.0",
-		"gulp": "^3.9.0",
-		"istanbul": "^0.4.4",
-		"mocha": "^5.0.0",
-		"should": "^13.1.2",
-		"vinyl": "^2.0.2"
+		"gulp": "^4.0.0",
+		"istanbul": "^0.4.5",
+		"mocha": "^5.2.0",
+		"should": "^13.2.1",
+		"vinyl": "^2.2.0"
 	}
 }

README.md

@@ -1,10 +0,10 @@
-# gulp-eslint [![Build Status](https://travis-ci.org/adametry/gulp-eslint.svg)](https://travis-ci.org/adametry/gulp-eslint) [![Coverage Status](https://img.shields.io/coveralls/adametry/gulp-eslint.svg)](https://coveralls.io/r/adametry/gulp-eslint)
+# gulp-eslint [![Build Status](https://travis-ci.org/adametry/gulp-eslint.svg)](https://travis-ci.org/adametry/gulp-eslint) [![Coverage Status](https://img.shields.io/coveralls/adametry/gulp-eslint.svg)](https://coveralls.io/github/adametry/gulp-eslint)
 
-> A [gulp](https://gulpjs.com/) plugin for [ESLint](https://eslint.org/).
+> A [gulp](https://gulpjs.com/) plugin for [ESLint](https://eslint.org/)
 
 ## Installation
 
-[Use npm](https://docs.npmjs.com/cli/install).
+[Use](https://docs.npmjs.com/cli/install) [npm](https://docs.npmjs.com/getting-started/what-is-npm).
 
-```sh
+```
 npm install gulp-eslint
@@ -16,11 +16,7 @@ ```
 ```javascript
-const gulp = require('gulp');
+const {src, task} = require('gulp');
 const eslint = require('gulp-eslint');
 
-gulp.task('lint', () => {
-    // ESLint ignores files with "node_modules" paths.
-    // So, it's best to have gulp ignore the directory as well.
-    // Also, Be sure to return the stream from the task;
-    // Otherwise, the task may end before the stream has finished.
-    return gulp.src(['**/*.js','!node_modules/**'])
+task('default', () => {
+    return src(['scripts/*.js'])
         // eslint() attaches the lint output to the "eslint" property
@@ -36,6 +32,2 @@ // of the file object so it can be used by other modules.
 });
-
-gulp.task('default', ['lint'], function () {
-    // This will only run if the lint task is successful...
-});
 ```
@@ -42,0 +34,0 @@

util.js

 'use strict';
 
-const Transform = require('stream').Transform;
+const {Transform} = require('stream');
 const PluginError = require('plugin-error');
 const fancyLog = require('fancy-log');
-const CLIEngine = require('eslint').CLIEngine;
+const {CLIEngine} = require('eslint');
 
@@ -43,5 +43,5 @@ /**
 			severity: 1,
-			message: file.path.indexOf('node_modules/') < 0 ?
-				'File ignored because of .eslintignore file' :
-				'File ignored because it has a node_modules/** path'
+			message: file.path.includes('node_modules/') ?
+				'File ignored because it has a node_modules/** path' :
+				'File ignored because of .eslintignore file'
 		}],
@@ -48,0 +48,0 @@ errorCount: 0,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

421

increased by2.93%

Worsened metrics

Total package byte prevSize

30957

decreased by-0.28%

Number of lines in readme file

270

decreased by-2.88%

Dependency changes

• + Added@babel/code-frame@7.24.7(transitive)

• + Added@babel/helper-validator-identifier@7.24.7(transitive)

• + Added@babel/highlight@7.24.7(transitive)

• + Addedacorn@6.4.2(transitive)

• + Addedacorn-jsx@5.3.2(transitive)

• + Addedajv@6.12.6(transitive)

• + Addedansi-regex@4.1.1(transitive)

• + Addedastral-regex@1.0.0(transitive)

• + Addedcallsites@3.1.0(transitive)

• + Addedchardet@0.7.0(transitive)

• + Addedcross-spawn@6.0.5(transitive)

• + Addeddebug@4.3.7(transitive)

• + Addeddoctrine@3.0.0(transitive)

• + Addedemoji-regex@7.0.3(transitive)

• + Addedeslint@5.16.0(transitive)

• + Addedeslint-scope@4.0.3(transitive)

• + Addedeslint-utils@1.4.3(transitive)

• + Addedespree@5.0.1(transitive)

• + Addedexternal-editor@3.1.0(transitive)

• + Addedfast-deep-equal@3.1.3(transitive)

• + Addedfile-entry-cache@5.0.1(transitive)

• + Addedflat-cache@2.0.1(transitive)

• + Addedflatted@2.0.2(transitive)

• + Addedignore@4.0.6(transitive)

• + Addedimport-fresh@3.3.0(transitive)

• + Addedinquirer@6.5.2(transitive)

• + Addedjs-tokens@4.0.0(transitive)

• + Addedjson-schema-traverse@0.4.1(transitive)

• + Addednice-try@1.0.5(transitive)

• + Addedparent-module@1.0.1(transitive)

• + Addedpath-key@2.0.1(transitive)

• + Addedpicocolors@1.1.0(transitive)

• + Addedpunycode@2.3.1(transitive)

• + Addedregexpp@2.0.1(transitive)

• + Addedresolve-from@4.0.0(transitive)

• + Addedrxjs@6.6.7(transitive)

• + Addedslice-ansi@2.1.0(transitive)

• + Addedstring-width@3.1.0(transitive)

• + Addedstrip-ansi@5.2.0(transitive)

• + Addedtable@5.4.6(transitive)

• + Addedtslib@1.14.1(transitive)

• + Addeduri-js@4.4.1(transitive)

• + Addedwrite@1.0.3(transitive)

• - Removedacorn@3.3.05.7.4(transitive)

• - Removedacorn-jsx@3.0.1(transitive)

• - Removedajv@5.5.2(transitive)

• - Removedajv-keywords@2.1.1(transitive)

• - Removedansi-regex@2.1.1(transitive)

• - Removedansi-styles@2.2.1(transitive)

• - Removedbabel-code-frame@6.26.0(transitive)

• - Removedbuffer-from@1.1.2(transitive)

• - Removedcaller-path@0.1.0(transitive)

• - Removedcallsites@0.2.0(transitive)

• - Removedchalk@1.1.3(transitive)

• - Removedchardet@0.4.2(transitive)

• - Removedcircular-json@0.3.3(transitive)

• - Removedco@4.6.0(transitive)

• - Removedconcat-stream@1.6.2(transitive)

• - Removedcore-util-is@1.0.3(transitive)

• - Removedcross-spawn@5.1.0(transitive)

• - Removeddebug@3.2.7(transitive)

• - Removeddoctrine@2.1.0(transitive)

• - Removedeslint@4.19.1(transitive)

• - Removedeslint-scope@3.7.3(transitive)

• - Removedespree@3.5.4(transitive)

• - Removedexternal-editor@2.2.0(transitive)

• - Removedfast-deep-equal@1.1.0(transitive)

• - Removedfile-entry-cache@2.0.0(transitive)

• - Removedflat-cache@1.3.4(transitive)

• - Removedgraceful-fs@4.2.11(transitive)

• - Removedhas-ansi@2.0.0(transitive)

• - Removedignore@3.3.10(transitive)

• - Removedinquirer@3.3.0(transitive)

• - Removedis-resolvable@1.1.0(transitive)

• - Removedisarray@1.0.0(transitive)

• - Removedjs-tokens@3.0.2(transitive)

• - Removedjson-schema-traverse@0.3.1(transitive)

• - Removedlru-cache@4.1.5(transitive)

• - Removedobject-assign@4.1.1(transitive)

• - Removedpluralize@7.0.0(transitive)

• - Removedprocess-nextick-args@2.0.1(transitive)

• - Removedpseudomap@1.0.2(transitive)

• - Removedreadable-stream@2.3.8(transitive)

• - Removedregexpp@1.1.0(transitive)

• - Removedrequire-uncached@1.0.3(transitive)

• - Removedresolve-from@1.0.1(transitive)

• - Removedrx-lite@4.0.8(transitive)

• - Removedrx-lite-aggregates@4.0.8(transitive)

• - Removedsafe-buffer@5.1.2(transitive)

• - Removedslice-ansi@1.0.0(transitive)

• - Removedstring_decoder@1.1.1(transitive)

• - Removedstrip-ansi@3.0.1(transitive)

• - Removedsupports-color@2.0.0(transitive)

• - Removedtable@4.0.2(transitive)

• - Removedtypedarray@0.0.6(transitive)

• - Removedutil-deprecate@1.0.2(transitive)

• - Removedwrite@0.2.1(transitive)

• - Removedyallist@2.1.2(transitive)

• Updatedeslint@^5.0.1

• Updatedplugin-error@^1.0.1