harmonics - npm Package Compare versions

Comparing version 1.0.6 to 1.0.7

package.json

 {
   "name": "harmonics",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Tools and utilities for a generic representation of scales, chords, progressions etc. for use in music software, music related web & mobile apps, VST/VCV plugins and Max for Live devices.",
@@ -5,0 +5,0 @@ "main": "main.js",

src/scalesAndChords.js

@@ -58,3 +58,3 @@ const scaleMaps = require('../gen/scaleMaps.json');
   const rootOctave = rootOctaveScale.slice(0, indexOfFirstSpace);
-  const root = sharpToFlat(rootOctave.replace(/\d/g, ''));
+  const root = sharpToFlat(rootOctave.replace(/\d/g, '').toUpperCase());
   const octave = +rootOctave.replace(/\D/g, '');
@@ -61,0 +61,0 @@

src/scalesAndChords.test.js

@@ -87,2 +87,21 @@ const scalesAndChords = require('./scalesAndChords');
 
+test('accepts lowercase note name', () => {
+  expect(scalesAndChords.scale('c5 phrygian')).toStrictEqual([
+    'C5',
+    'Db5',
+    'Eb5',
+    'F5',
+    'G5',
+    'Ab5',
+    'Bb5',
+  ]);
+
+  expect(scalesAndChords.chord('c5 maj7')).toStrictEqual([
+    'C5',
+    'E5',
+    'G5',
+    'B5',
+  ]);
+});
+
 test('returns the notes of a chord if available', () => {
@@ -89,0 +108,0 @@ expect(scalesAndChords.chord('C4 M')).toStrictEqual(['C4', 'E4', 'G4']);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25175

increased by1.25%

Lines of code

501

increased by3.51%

No dependency changes