homebridge-syntex-dynamic-platform - npm Package Compare versions

Comparing version 1.0.8-b65 to 1.0.8-b66

package.json

 {
 	"name": "homebridge-syntex-dynamic-platform",
-	"version": "1.0.8-b65",
+	"version": "1.0.8-b66",
 	"description": "A Dynamic Platform Accessory",
@@ -5,0 +5,0 @@ "main": "main.js",

src/accessories/fan.js

@@ -22,9 +22,24 @@ const BaseService = require('../base');
 		this.service.getCharacteristic(this.Characteristic.On).on('get', this.getState.bind(this)).on('set', this.setState.bind(this));
-		this.service.getCharacteristic(this.Characteristic.RotationSpeed).on('get', this.getRotationSpeed.bind(this)).on('set', this.setRotationSpeed.bind(this));
-		this.service.getCharacteristic(this.Characteristic.RotationDirection).on('get', this.getRotationDirection.bind(this)).on('set', this.setRotationDirection.bind(this));
-
 		this.service.getCharacteristic(this.Characteristic.On).updateValue(this.value);
-		this.service.getCharacteristic(this.Characteristic.RotationSpeed).updateValue(this.speed);
-		this.service.getCharacteristic(this.Characteristic.RotationDirection).updateValue(this.direction);
 
+		if(this.options.characteristics.speed != false)
+		{
+			this.service.getCharacteristic(this.Characteristic.RotationSpeed).on('get', this.getRotationSpeed.bind(this)).on('set', this.setRotationSpeed.bind(this));
+			this.service.getCharacteristic(this.Characteristic.RotationSpeed).updateValue(this.speed);
+		}
+		else
+		{
+			this.service.removeCharacteristic(this.service.getCharacteristic(this.Characteristic.RotationSpeed));
+		}
+
+		if(this.options.characteristics.direction != false)
+		{
+			this.service.getCharacteristic(this.Characteristic.RotationDirection).on('get', this.getRotationDirection.bind(this)).on('set', this.setRotationDirection.bind(this));
+			this.service.getCharacteristic(this.Characteristic.RotationDirection).updateValue(this.direction);
+		}
+		else
+		{
+			this.service.removeCharacteristic(this.service.getCharacteristic(this.Characteristic.RotationDirection));
+		}
+
 		this.changeHandler = (state) => {
@@ -31,0 +46,0 @@

src/base.js

@@ -37,2 +37,3 @@ module.exports = class BaseService
 		this.options.requests = serviceConfig.requests || [];
+		this.options.characteristics = serviceConfig.characteristics || {};
 
@@ -39,0 +40,0 @@ this.service = this.createService(serviceType, serviceConfig.type, serviceConfig.subtype);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

93472

increased by0.49%

Lines of code

2693

increased by0.56%

No dependency changes