honeycomb-beeline - npm Package Compare versions

Comparing version 3.2.0 to 3.2.1

CHANGELOG.md

 # beeline-nodejs changelog
 
+## 3.2.1 [2022-01-06]
+
+### Fixes
+
+- Check parent exists during instrumentation (#525) | [Asgaroth](https://github.com/Asgaroth)
+- Use beforeEach() and afterEach() in tests (#524) | [@JamieDanielson](https://github.com/JamieDanielson)
+
+### Maintenance
+
+- Bump typescript from 4.5.2 to 4.5.4 (#526)
+- Bump @typescript-eslint/parser from 5.6.0 to 5.9.0 (#527)
+- Bump lint-staged from 12.1.2 to 12.1.5 (#528)
+- Bump @typescript-eslint/eslint-plugin from 5.6.0 to 5.9.0 (#529)
+- Bump fastify from 3.24.1 to 3.25.3 (#522)
+- Bump @opentelemetry/api from 1.0.3 to 1.0.4 (#521)
+- Bump express from 4.17.1 to 4.17.2 (#523)
+- Add re-triage workflow (#517) | [@vreynolds](https://github.com/vreynolds)
+
 ## 3.2.0 [2021-12-22]
@@ -4,0 +22,0 @@

lib/instrumentation.js

@@ -74,3 +74,3 @@ /* eslint-env node */
 const instrumentLoad = (exports.instrumentLoad = (mod, loadRequest, parent, opts = {}) => {
-  if (parent.id.includes(`node_modules/${pkg.name}`) || !enabledInstrumentations.has(loadRequest)) {
+  if (!parent || parent.id.includes(`node_modules/${pkg.name}`) || !enabledInstrumentations.has(loadRequest)) {
     // no magic here
@@ -77,0 +77,0 @@ return mod;

lib/instrumentation.test.js

@@ -105,1 +105,9 @@ /* eslint-env node, jest */
 });
+
+test("don't instrument module if parent is null", () => {
+  instrumentation.clearInstrumentationForTesting();
+  let fakeExpress = createFakeExpress();
+  let m = instrumentation.instrumentLoad(fakeExpress, "express", null);
+  expect(m).toBe(fakeExpress);
+  expect(m.__wrapped).toBeUndefined();
+});

lib/instrumentation/child_process.test.js

@@ -14,3 +14,8 @@ /* eslint-env node, jest */
 
-beforeAll(() => api.configure({ impl: "mock" }));
+beforeEach(() => {
+  api.configure({ impl: "mock" });
+});
+afterEach(() => {
+  api._resetForTesting();
+});
 
@@ -17,0 +22,0 @@ test("exec 'echo hi' works", (done) => {

lib/instrumentation/express.test.js

@@ -13,2 +13,9 @@ /* eslint-env node, jest */
 
+beforeEach(() => {
+  api.configure({ impl: "mock" });
+});
+afterEach(() => {
+  api._resetForTesting();
+});
+
 describe("userContext", () => {
@@ -31,3 +38,2 @@ function runCase(opts, done) {
 
-    api.configure({ impl: "mock" });
     initializeTestApp();
@@ -68,3 +74,2 @@
         );
-        api._resetForTesting();
         done();
@@ -109,8 +114,4 @@ });
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -149,8 +150,4 @@ test("it's called even if req.user is undefined", (done) => {
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -199,8 +196,4 @@ test("it correctly sends the matched path", (done) => {
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -236,8 +229,4 @@ test("X-Request-ID works", (done) => {
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -273,8 +262,4 @@ test("X-Amzn-Trace-Id works", (done) => {
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -309,3 +294,2 @@ test("X-Request-ID > X-Amzn-Trace-Id", (done) => {
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     hooks.configure({
@@ -319,3 +303,2 @@ httpTraceParserHook: () => {
   afterEach(() => {
-    api._resetForTesting();
     hooks.configure({});
@@ -353,8 +336,4 @@ });
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     initializeTestApp();
   });
-  afterEach(() => {
-    api._resetForTesting();
-  });
 
@@ -394,7 +373,5 @@ test("returns supplied X-Request-Id (calling the traceIdSource function)", (done) => {
   beforeAll(() => {
-    api.configure({ impl: "mock" });
     askForIssue = api._askForIssue;
   });
   afterAll(() => {
-    api._resetForTesting();
     api._askForIssue = askForIssue;
@@ -401,0 +378,0 @@ });

lib/instrumentation/fastify.test.js

@@ -10,2 +10,9 @@ /* eslint-env node, jest */
 
+beforeEach(() => {
+  api.configure({ impl: "mock" });
+});
+afterEach(() => {
+  api._resetForTesting();
+});
+
 describe("userContext", () => {
@@ -32,3 +39,2 @@ function runCase(opts, done) {
 
-    api.configure({ impl: "mock" });
     initializeTestApp().then((app) => {
@@ -75,3 +81,2 @@ request(app.server)
           );
-          api._resetForTesting();
           app.close(done);
@@ -122,3 +127,2 @@ });
   test("it's called even if req.user is undefined", (done) => {
-    api.configure({ impl: "mock" });
     initializeTestServer().then((app) => {
@@ -132,3 +136,2 @@ request(app.server)
           expect(ev["request.user.random"]).toBe("stuff");
-          api._resetForTesting();
           app.close(done);
@@ -161,3 +164,2 @@ });
 
-    api.configure({ impl: "mock" });
     initializeTestServer().then((app) => {
@@ -178,3 +180,2 @@ let r = request(app.server).get("/");
 
-        api._resetForTesting();
         app.close(done);
@@ -229,3 +230,2 @@ });
   beforeEach(() => {
-    api.configure({ impl: "mock" });
     hooks.configure({
@@ -238,3 +238,2 @@ httpTraceParserHook: () => {
   afterEach(() => {
-    api._resetForTesting();
     hooks.configure({});
@@ -277,3 +276,2 @@ });
 
-    api.configure({ impl: "mock" });
     initializeTestServer().then((app) => {
@@ -294,3 +292,2 @@ let r = request(app.server).get("/");
 
-        api._resetForTesting();
         app.close(done);
@@ -297,0 +294,0 @@ });

lib/instrumentation/pg.test.js

@@ -8,2 +8,9 @@ /* eslint-env node, jest */
 
+beforeEach(() => {
+  api.configure({ impl: "mock" });
+});
+afterEach(() => {
+  api._resetForTesting();
+});
+
 const assertEventFields = (extraFields) => {
@@ -57,10 +64,2 @@ const events = api._apiForTesting().sentEvents;
 
-  beforeEach(() => {
-    api.configure({ impl: "mock" });
-  });
-
-  afterEach(() => {
-    api._resetForTesting();
-  });
-
   describe("basic query", () => {
@@ -67,0 +66,0 @@ test("with no values and callback", (done) => {

lib/instrumentation/react-dom-server.test.js

@@ -11,5 +11,8 @@ /* eslint-env node, jest */
 
-beforeAll(() => {
+beforeEach(() => {
   api.configure({ impl: "mock" });
 });
+afterEach(() => {
+  api._resetForTesting();
+});
 
@@ -16,0 +19,0 @@ describe("renderToString", () => {

package.json

@@ -9,3 +9,3 @@ {
   "license": "Apache-2.0",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "repository": {
@@ -12,0 +12,0 @@ "type": "git",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

252644

increased by0.09%

Worsened metrics

Lines of code

5971

decreased by-0.22%

No dependency changes