html-pdf - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0

Changelog.md

@@ -0,1 +1,8 @@
+1.2.0
+=====
+- Add `options.phantomArgs` option requested in [#22](https://github.com/marcbachmann/node-html-pdf/issues/22)
+- Also load CSS of html head in PDF header & footer [#31](https://github.com/marcbachmann/node-html-pdf/issues/31), [#27](https://github.com/marcbachmann/node-html-pdf/issues/27)
+- Support iojs by upgrading the phantomjs module to v1.9.16
+
+
 1.1.0
@@ -2,0 +9,0 @@ =====

lib/pdf.js

@@ -97,3 +97,3 @@ // Generated by CoffeeScript 1.9.1
       var child, stderr, stdout, timeout;
-      child = childprocess.spawn(this.options.phantomPath, [this.script]);
+      child = childprocess.spawn(this.options.phantomPath, [this.script].concat(this.options.phantomArgs));
       stdout = [];
@@ -100,0 +100,0 @@ stderr = [];

lib/scripts/pdf_a4_portrait.js

@@ -63,4 +63,7 @@ // Generated by CoffeeScript 1.9.1
   content = page.evaluate(function() {
-    var $body, $footer, $header, body, footer, header, ref1, styles;
-    styles = ((ref1 = document.querySelector('head style')) != null ? ref1.outerHTML : void 0) || '';
+    var $body, $footer, $header, body, footer, header, styles;
+    styles = document.querySelectorAll('link,style');
+    styles = Array.prototype.reduce.call(styles, (function(string, node) {
+      return string + node.outerHTML;
+    }), '');
     if ($header = document.getElementById('pageHeader')) {
@@ -67,0 +70,0 @@ header = $header.outerHTML;

package.json

 {
   "name": "html-pdf",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "HTML to PDF converter that uses phantomjs",
@@ -20,3 +20,3 @@ "main": "lib/index.js",
   "optionalDependencies": {
-    "phantomjs": "^1.9.8"
+    "phantomjs": "^1.9.16"
   },
@@ -23,0 +23,0 @@ "repository": {

README.md

@@ -85,2 +85,3 @@ # node-html-pdf
   "phantomPath": "./node_modules/phantomjs/bin/phantomjs", // PhantomJS binary which should get downloaded automatically
+  "phantomArgs": [], // array of strings used as phantomjs args e.g. ["--ignore-ssl-errors=yes"]
   "script": '/url',           // Absolute path to a custom phantomjs script, use the file in lib/scripts as example
@@ -87,0 +88,0 @@ "timeout": 30000           // Timeout that will cancel phantomjs, in milliseconds

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

28121

increased by3.83%

Lines of code

277

increased by1.09%

Number of lines in readme file

94

increased by1.08%

No dependency changes