http-basic - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

index.js

@@ -65,7 +65,7 @@ 'use strict';
           delete res.headers['content-encoding'];
-          res.body = res.body.pipe(zlib.createGunzip()).pipe(new PassThrough());
+          res.body = res.body.pipe(zlib.createGunzip());
           break;
         case 'deflate':
           delete res.headers['content-encoding'];
-          res.body = res.body.pipe(zlib.createInflate()).pipe(new PassThrough());
+          res.body = res.body.pipe(zlib.createInflate());
           break;
@@ -84,2 +84,4 @@ }
       if (options.followRedirects && isRedirect(res.statusCode)) {
+        // prevent leakage of file handles
+        res.body.resume();
         return request(duplex ? 'GET' : method, res.headers.location, options, callback);
@@ -113,2 +115,4 @@ } else {
         if (res.statusCode === 304 && cachedResponse) { // Not Modified
+          // prevent leakage of file handles
+          res.body.resume();
           res = new Response(cachedResponse.statusCode, cachedResponse.headers, cachedResponse.body);
@@ -119,2 +123,4 @@ res.fromCache = true;
         } else if (cacheUtils.canCache(res)) {
+          // prevent leakage of file handles
+          cachedResponse && cachedResponse.body.resume();
           var cachedResponseBody = new PassThrough();
@@ -131,2 +137,4 @@ var resultResponseBody = new PassThrough();
         } else {
+          // prevent leakage of file handles
+          cachedResponse && cachedResponse.body.resume();
           return callback(null, res);
@@ -133,0 +141,0 @@ }

lib/cache-utils.js

@@ -0,0 +0,0 @@ 'use strict';

lib/file-cache.js

@@ -0,0 +0,0 @@ 'use strict';

lib/memory-cache.js

@@ -0,0 +0,0 @@ 'use strict';

package.json

 {
   "name": "http-basic",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Very low level wrapper arround http.request/https.request",
@@ -5,0 +5,0 @@ "keywords": [

README.md

@@ -0,0 +0,0 @@ # http-basic

test/gzip.js

@@ -0,0 +0,0 @@ 'use strict';

test/index.js

@@ -0,0 +0,0 @@ 'use strict';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

341

increased by2.4%

Worsened metrics

Total package byte prevSize

16724

decreased by-1.09%

No dependency changes