http-browserify - npm Package Compare versions

Comparing version 0.1.4 to 0.1.5

lib/request.js

@@ -20,12 +20,14 @@ var Stream = require('stream');
     if (params.headers) {
-        Object.keys(params.headers).forEach(function (key) {
+        var keys = objectKeys(params.headers);
+        for (var i = 0; i < keys.length; i++) {
+            var key = keys[i];
             if (!self.isSafeRequestHeader(key)) return;
             var value = params.headers[key];
-            if (Array.isArray(value)) {
-                value.forEach(function (v) {
-                    xhr.setRequestHeader(key, v);
-                });
+            if (isArray(value)) {
+                for (var j = 0; j < value.length; j++) {
+                    xhr.setRequestHeader(key, value[j]);
+                }
             }
             else xhr.setRequestHeader(key, value)
-        });
+        }
     }
@@ -50,4 +52,3 @@
 Request.prototype.setHeader = function (key, value) {
-    if ((Array.isArray && Array.isArray(value))
-    || value instanceof Array) {
+    if (isArray(value)) {
         for (var i = 0; i < value.length; i++) {
@@ -106,1 +107,11 @@ this.xhr.setRequestHeader(key, value[i]);
 };
+
+var objectKeys = Object.keys || function (obj) {
+    var keys = [];
+    for (var key in obj) keys.push(key);
+    return keys;
+};
+
+var isArray = Array.isArray || function (xs) {
+    return Object.prototype.toString.call(xs) === '[object Array]';
+};

lib/response.js

@@ -27,4 +27,4 @@ var Stream = require('stream');
             if (headers[key] !== undefined) {
-                if ((Array.isArray && Array.isArray(headers[key]))
-                || headers[key] instanceof Array) {
+            
+                if (isArray(headers[key])) {
                     headers[key].push(value);
@@ -117,1 +117,5 @@ }
 };
+
+var isArray = Array.isArray || function (xs) {
+    return Object.prototype.toString.call(xs) === '[object Array]';
+};

package.json

 {
     "name" : "http-browserify",
-    "version" : "0.1.4",
+    "version" : "0.1.5",
     "description" : "http module compatability for browserify",
@@ -5,0 +5,0 @@ "main" : "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

14900

increased by2.24%

Lines of code

364

increased by3.12%

No dependency changes