ibm-cloud-sdk-core - npm Package Compare versions

Comparing version 0.3.4 to 0.3.5

auth/iam-token-manager-v1.d.ts

@@ -25,2 +25,3 @@ /**
     iamClientSecret?: string;
+    requestWrapper?: any;
 };
@@ -27,0 +28,0 @@ export interface IamTokenData {

auth/icp4d-token-manager-v1.d.ts

@@ -23,2 +23,3 @@ /**
     disableSslVerification?: boolean;
+    requestWrapper?: any;
 };
@@ -25,0 +26,0 @@ export interface IcpTokenData {

auth/jwt-token-manager-v1.d.ts

@@ -19,2 +19,3 @@ /**
     url?: string;
+    requestWrapper?: any;
 };
@@ -21,0 +22,0 @@ export declare class JwtTokenManagerV1 {

auth/jwt-token-manager-v1.js

@@ -46,3 +46,4 @@ "use strict";
         }
-        this.requestWrapperInstance = new requestwrapper_1.RequestWrapper();
+        // not required, but the SDK will always pass in a request wrapper instance
+        this.requestWrapperInstance = options.requestWrapper || new requestwrapper_1.RequestWrapper();
     }
@@ -49,0 +50,0 @@ /**

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [0.3.5](https://github.com/IBM/node-sdk-core/compare/v0.3.4...v0.3.5) (2019-08-07)
+
+
+### Bug Fixes
+
+* share service request wrapper instance with token managers ([#36](https://github.com/IBM/node-sdk-core/issues/36)) ([e7609e2](https://github.com/IBM/node-sdk-core/commit/e7609e2))
+
 ## [0.3.4](https://github.com/IBM/node-sdk-core/compare/v0.3.3...v0.3.4) (2019-08-05)
@@ -2,0 +9,0 @@

lib/base_service.js

@@ -122,2 +122,3 @@ "use strict";
         this._options.rejectUnauthorized = !options.disable_ssl_verification;
+        this.requestWrapperInstance = new requestwrapper_1.RequestWrapper(this._options);
         if (_options.authentication_type === 'iam' || hasIamCredentials(_options)) {
@@ -130,2 +131,3 @@ this.tokenManager = new auth_1.IamTokenManagerV1({
                 iamClientSecret: _options.iam_client_secret,
+                requestWrapper: this.requestWrapperInstance,
             });
@@ -139,2 +141,3 @@ }
                 iamClientSecret: _options.iam_client_secret,
+                requestWrapper: this.requestWrapperInstance,
             });
@@ -152,2 +155,3 @@ }
                 disableSslVerification: options.disable_ssl_verification,
+                requestWrapper: this.requestWrapperInstance,
             });
@@ -158,3 +162,2 @@ }
         }
-        this.requestWrapperInstance = new requestwrapper_1.RequestWrapper(this._options);
     }
@@ -226,2 +229,3 @@ /**
                 disableSslVerification: this._options.disable_ssl_verification,
+                requestWrapper: this.requestWrapperInstance,
             });
@@ -232,2 +236,3 @@ }
                 accessToken: access_token,
+                requestWrapper: this.requestWrapperInstance,
             });
@@ -234,0 +239,0 @@ }

package.json

 {
   "name": "ibm-cloud-sdk-core",
-  "version": "0.3.4",
+  "version": "0.3.5",
   "description": "Core functionality to support SDKs generated with IBM's OpenAPI 3 SDK Generator.",
@@ -5,0 +5,0 @@ "main": "./index",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

153550

increased by0.64%

Lines of code

2332

increased by0.39%

No dependency changes