ioredis - npm Package Compare versions

Comparing version 4.16.3 to 4.17.0

built/cluster/ClusterSubscriber.js

@@ -61,2 +61,3 @@ "use strict";
             host: options.host,
+            username: options.username,
             password: options.password,
@@ -63,0 +64,0 @@ enableReadyCheck: true,

built/connectors/SentinelConnector/index.js

@@ -176,2 +176,3 @@ "use strict";
             host: endpoint.host,
+            username: this.options.sentinelUsername || null,
             password: this.options.sentinelPassword || null,
@@ -178,0 +179,0 @@ family: endpoint.family ||

built/redis/event_handler.js

@@ -22,9 +22,15 @@ "use strict";
                 if (err) {
-                    if (err.message.indexOf("no password is set") === -1) {
+                    if (err.message.indexOf("no password is set") !== -1) {
+                        console.warn("[WARN] Redis server does not require a password, but a password was supplied.");
+                    }
+                    else if (err.message.indexOf("without any password configured for the default user") !== -1) {
+                        console.warn("[WARN] This Redis server's `default` user does not require a password, but a password was supplied");
+                    }
+                    else if (err.message.indexOf("wrong number of arguments for 'auth' command") !== -1) {
+                        console.warn(`[ERROR] The server returned "wrong number of arguments for 'auth' command". You are probably passing both username and password to Redis version 5 or below. You should only pass the 'password' option for Redis version 5 and under.`);
+                    }
+                    else {
                         flushed = true;
                         self.recoverFromFatalError(err, err);
                     }
-                    else {
-                        console.warn("[WARN] Redis server does not require a password, but a password was supplied.");
-                    }
                 }
@@ -31,0 +37,0 @@ });

built/redis/index.js

@@ -41,2 +41,3 @@ "use strict";
  * @param {number} [options.db=0] - Database index to use.
+ * @param {string} [options.username=null] - If set, client will send AUTH command with this user and password when connected.
  * @param {string} [options.password=null] - If set, client will send AUTH command
@@ -244,3 +245,5 @@ * with the value of this option when connected.
             select: options.db,
-            auth: options.password,
+            auth: options.username
+                ? [options.username, options.password]
+                : options.password,
             subscriber: false,
@@ -247,0 +250,0 @@ };

built/redis/RedisOptions.js

@@ -26,2 +26,3 @@ "use strict";
     // Status
+    username: null,
     password: null,
@@ -28,0 +29,0 @@ db: 0,

built/utils/index.js

@@ -259,3 +259,7 @@ "use strict";
     if (parsed.auth) {
-        result.password = parsed.auth.split(":")[1];
+        const parsedAuth = parsed.auth.split(":");
+        if (parsedAuth[0]) {
+            result.username = parsedAuth[0];
+        }
+        result.password = parsedAuth[1];
     }
@@ -262,0 +266,0 @@ if (parsed.pathname) {

Changelog.md

@@ -0,1 +1,8 @@
+# [4.17.0](https://github.com/luin/ioredis/compare/v4.16.3...v4.17.0) (2020-05-16)
+
+
+### Features
+
+* add auth support for Redis 6 ([#1130](https://github.com/luin/ioredis/issues/1130)) ([ad5b455](https://github.com/luin/ioredis/commit/ad5b45587b2e378c15fa879cc72580c391c3c18d))
+
 ## [4.16.3](https://github.com/luin/ioredis/compare/v4.16.2...v4.16.3) (2020-04-21)
@@ -2,0 +9,0 @@

package.json

 {
   "name": "ioredis",
-  "version": "4.16.3",
+  "version": "4.17.0",
   "description": "A robust, performance-focused and full-featured Redis client for Node.js.",
@@ -11,2 +11,3 @@ "main": "built/index.js",
     "test": "TS_NODE_TRANSPILE_ONLY=true TS_NODE_LOG_ERROR=true NODE_ENV=test mocha \"test/**/*.ts\"",
+    "test-single": "TS_NODE_TRANSPILE_ONLY=true TS_NODE_LOG_ERROR=true NODE_ENV=test mocha $1",
     "lint": "eslint --ext .js,.ts .",
@@ -13,0 +14,0 @@ "format": "prettier --write \"{,!(node_modules)/**/}*.{js,ts}\"",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

248737

increased by0.61%

Lines of code

4296

increased by0.37%

No dependency changes