isolated-vm - npm Package Compare versions

Comparing version 6.0.1 to 6.0.2

package.json

 {
   "name": "isolated-vm",
-  "version": "6.0.1",
+  "version": "6.0.2",
   "description": "Access to multiple isolates",
@@ -5,0 +5,0 @@ "main": "isolated-vm.js",

src/isolate/class_handle.h

@@ -95,3 +95,7 @@ #pragma once
 				v8::Local<v8::String> name_handle = v8_symbol(name);
-				proto->SetNativeDataProperty(name_handle, impl.getter.callback, impl.setter.callback);
+				v8::Local<v8::FunctionTemplate> setter;
+				if (impl.setter.callback != nullptr) {
+					setter = v8::FunctionTemplate::New(isolate, impl.setter.callback, name_handle);
+				}
+				proto->SetAccessorProperty(name_handle, v8::FunctionTemplate::New(isolate, impl.getter.callback, {}), setter);
 				Add(args...);
@@ -98,0 +102,0 @@ }

src/isolate/generic/callbacks.h

@@ -160,10 +160,8 @@ #pragma once
 // Member getters and setters
-struct MemberGetterHolder : GenericCallback<v8::AccessorNameGetterCallback,
-		v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&> {
-	using GenericCallback::GenericCallback;
+struct MemberGetterHolder : FunctionCallbackImpl {
+	using FunctionCallbackImpl::FunctionCallbackImpl;
 };
 
-struct MemberSetterHolder : GenericCallback<v8::AccessorNameSetterCallback,
-		v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&> {
-	using GenericCallback::GenericCallback;
+struct MemberSetterHolder : FunctionCallbackImpl {
+	using FunctionCallbackImpl::FunctionCallbackImpl;
 };
@@ -233,8 +231,4 @@
 	constexpr MemberAccessor() : MemberAccessorHolder{
-		detail::MemberGetterHolder{detail::MemberGetterHolder::ToCallback<
-			0, typename UnboundGetter::type, UnboundGetter::template invoke<Getter>
-		>()},
-		detail::MemberSetterHolder{detail::MemberSetterHolder::ToCallback<
-			0, typename UnboundSetter::type, UnboundSetter::template invoke<Setter>
-		>()}
+		detail::MemberGetterHolder{detail::MemberGetterHolder::ToCallback<-1, typename UnboundGetter::type, UnboundGetter::template invoke<Getter>>(), 0},
+		detail::MemberSetterHolder{detail::MemberSetterHolder::ToCallback<-1, typename UnboundSetter::type, UnboundSetter::template invoke<Setter>>(), 1},
 	} {}
@@ -253,6 +247,4 @@
 	constexpr MemberAccessor() : MemberAccessorHolder{
-		detail::MemberGetterHolder{detail::MemberGetterHolder::ToCallback<
-			0, typename UnboundGetter::type, UnboundGetter::template invoke<Getter>
-		>()},
-		detail::MemberSetterHolder{nullptr}
+		detail::MemberGetterHolder{detail::MemberGetterHolder::ToCallback<-1, typename UnboundGetter::type, UnboundGetter::template invoke<Getter>>(), 0},
+		detail::MemberSetterHolder{nullptr},
 	} {}
@@ -259,0 +251,0 @@

src/module/callback.cc

@@ -15,3 +15,3 @@ #include "callback.h"
  */
-static std::unique_ptr<CallbackHandle> CallbackHandle_New_Wrapper(Local<Value> This, Local<Function> fn, MaybeLocal<Object> options) {
+static std::unique_ptr<CallbackHandle> CallbackHandle_New_Wrapper(Local<Function> fn, MaybeLocal<Object> options) {
 	return CallbackHandle::New(fn, options);
@@ -18,0 +18,0 @@ }

No alert changes

Worsened metrics

Total package byte prevSize

523446

0

No dependency changes