it-batch - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

index.js

 'use strict'
 
 async function * batch (source, size) {
-  if (isNaN(size)) {
+  size = parseInt(size)
+
+  if (isNaN(size) || size < 1) {
     size = 1
@@ -6,0 +8,0 @@ }

package.json

 {
   "name": "it-batch",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Takes an async iterator that emits things and emits them as fixed size batches",
@@ -5,0 +5,0 @@ "main": "index.js",

test.js

@@ -19,1 +19,33 @@ import batch from './'
 })
+
+test('Should batch up entries with negative batch size', async (t) => {
+  const values = [0, 1, 2, 3, 4]
+  const batchSize = -1
+  const res = await all(batch(values, batchSize))
+
+  t.deepEqual(res, [[0], [1], [2], [3], [4]])
+})
+
+test('Should batch up entries with zero batch size', async (t) => {
+  const values = [0, 1, 2, 3, 4]
+  const batchSize = 0
+  const res = await all(batch(values, batchSize))
+
+  t.deepEqual(res, [[0], [1], [2], [3], [4]])
+})
+
+test('Should batch up entries with string batch size', async (t) => {
+  const values = [0, 1, 2, 3, 4]
+  const batchSize = '2'
+  const res = await all(batch(values, batchSize))
+
+  t.deepEqual(res, [[0, 1], [2, 3], [4]])
+})
+
+test('Should batch up entries with non-integer batch size', async (t) => {
+  const values = [0, 1, 2, 3, 4]
+  const batchSize = 2.5
+  const res = await all(batch(values, batchSize))
+
+  t.deepEqual(res, [[0, 1], [2, 3], [4]])
+})

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3644

increased by38.98%

Number of package files

5

increased by25%

Lines of code

58

increased by75.76%

No dependency changes