jasmine-growl-reporter - npm Package Compare versions

Comparing version 0.2.1 to 1.0.0

Gruntfile.js

@@ -1,6 +0,3 @@
-
 module.exports = function(grunt) {
-
   grunt.initConfig({
-
     pkg: grunt.file.readJSON('package.json'),
@@ -13,9 +10,6 @@
     jasmine_node: {
-      projectRoot: '.',
-      requirejs: false,
-      forceExit: true
+      all: {}
     },
 
     watch: {
-
       src: {
@@ -28,3 +22,2 @@ files: [ 'lib/**/*.js', 'spec/**/*.js' ],
 
-  grunt.loadNpmTasks('grunt-bump');
   grunt.loadNpmTasks('grunt-contrib-jshint');
@@ -31,0 +24,0 @@ grunt.loadNpmTasks('grunt-jasmine-node');

lib/reporter.js

@@ -1,2 +0,1 @@
-
 exports.inject = function(deps) {
@@ -8,39 +7,36 @@
 
-  var GrowlReporter = function() {
+  function GrowlReporter() {
+  }
+
+  GrowlReporter.prototype.jasmineStarted = function() {
+    this.startedAt = new Date();
+    this.counts = {
+      failed: 0,
+      pending: 0,
+      total: 0
+    };
   };
 
-  GrowlReporter.prototype = {
+  GrowlReporter.prototype.specStarted = function() {
+    this.counts.total++;
+  };
 
-    jasmineStarted: function() {
-      this.startedAt = new Date();
-      this.counts = {
-        failed: 0,
-        pending: 0,
-        total: 0
-      };
-    },
+  GrowlReporter.prototype.specDone = function(spec) {
+    switch (spec.status) {
+      case 'pending':
+        this.counts.pending++;
+        break;
+      case 'failed':
+        this.counts.failed++;
+        break;
+    }
+  };
 
-    specStarted: function() {
-      this.counts.total++;
-    },
+  GrowlReporter.prototype.jasmineDone = function() {
 
-    specDone: function(spec) {
-      switch (spec.status) {
-        case 'pending':
-          this.counts.pending++;
-          break;
-        case 'failed':
-          this.counts.failed++;
-          break;
-      }
-    },
-
-    jasmineDone: function() {
-
-      growl(growlMessage(this.counts), {
-        name: growlName,
-        title: growlTitle(this.counts, this.startedAt),
-        image: growlImage(this.counts)
-      });
-    }
+    growl(growlMessage(this.counts), {
+      name: growlName,
+      title: growlTitle(this.counts, this.startedAt),
+      image: growlImage(this.counts)
+    });
   };
@@ -47,0 +43,0 @@

package.json

 {
   "name": "jasmine-growl-reporter",
-  "version": "0.2.1",
+  "version": "1.0.0",
   "main": "./index.js",
@@ -9,11 +9,10 @@ "scripts": {
   "dependencies": {
-    "growl": "~1.7.0"
+    "growl": "^1.9.2"
   },
   "devDependencies": {
-    "grunt": "~0.4.3",
-    "grunt-bump": "~0.0.13",
-    "grunt-contrib-jshint": "~0.8.0",
-    "grunt-jasmine-node": "~0.1.0",
-    "grunt-contrib-watch": "~0.5.3",
-    "underscore": "~1.6.0"
+    "grunt": "^1.0.1",
+    "grunt-contrib-jshint": "^1.1.0",
+    "grunt-contrib-watch": "^1.0.0",
+    "grunt-jasmine-node": "~0.3.1",
+    "lodash": "^4.17.4"
   },
@@ -20,0 +19,0 @@ "homepage": "https://github.com/AlphaHydrae/jasmine-growl-reporter",

README.md

 # Jasmine Growl Reporter
 
-[![NPM version](https://badge.fury.io/js/jasmine-growl-reporter.png)](http://badge.fury.io/js/jasmine-growl-reporter)
-[![Dependency Status](https://gemnasium.com/AlphaHydrae/jasmine-growl-reporter.png)](https://gemnasium.com/AlphaHydrae/jasmine-growl-reporter)
-[![Build Status](https://secure.travis-ci.org/AlphaHydrae/jasmine-growl-reporter.png)](http://travis-ci.org/AlphaHydrae/jasmine-growl-reporter)
+[![NPM version](https://badge.fury.io/js/jasmine-growl-reporter.svg)](http://badge.fury.io/js/jasmine-growl-reporter)
+[![Dependency Status](https://gemnasium.com/AlphaHydrae/jasmine-growl-reporter.svg)](https://gemnasium.com/AlphaHydrae/jasmine-growl-reporter)
+[![Build Status](https://travis-ci.org/AlphaHydrae/jasmine-growl-reporter.svg?branch=master)](https://travis-ci.org/AlphaHydrae/jasmine-growl-reporter)
 
@@ -7,0 +7,0 @@ Growl notifications when running your Jasmine specs.

spec/matchers.js

@@ -0,8 +1,5 @@
+var _ = require('lodash');
 
-var _ = require('underscore');
-
 beforeEach(function() {
-
   this.addMatchers({
-
     toHaveNotified: function(message, options) {
@@ -9,0 +6,0 @@

spec/reporter.spec.js

@@ -1,3 +0,2 @@
-
-var _ = require('underscore'),
+var _ = require('lodash'),
     path = require('path'),
@@ -21,3 +20,4 @@ RunnerMock = require('./runnerMock'),
     growl = jasmine.createSpy();
-    reporter = new (growlReporterInjector({ growl: growl }))();
+    var Reporter = growlReporterInjector({ growl: growl });
+    reporter = new Reporter();
     runner = new RunnerMock(reporter);
@@ -40,3 +40,3 @@ });
     runner.suite(function() {
-      _.times(2, this.passTest, this);
+      _.times(2, this.passTest.bind(this));
     });
@@ -54,3 +54,3 @@
     runner.suite(function() {
-      _.times(3, this.failTest, this);
+      _.times(3, this.failTest.bind(this));
     });
@@ -68,4 +68,4 @@
     runner.suite(function() {
-      _.times(2, this.passTest, this);
-      _.times(4, this.failTest, this);
+      _.times(2, this.passTest.bind(this));
+      _.times(4, this.failTest.bind(this));
     });
@@ -83,3 +83,3 @@
     runner.suite(function() {
-      _.times(3, this.skipTest, this);
+      _.times(3, this.skipTest.bind(this));
     });
@@ -97,4 +97,4 @@
     runner.suite(function() {
-      _.times(1, this.passTest, this);
-      _.times(2, this.skipTest, this);
+      _.times(1, this.passTest.bind(this));
+      _.times(2, this.skipTest.bind(this));
     });
@@ -112,4 +112,4 @@
     runner.suite(function() {
-      _.times(4, this.skipTest, this);
-      _.times(5, this.failTest, this);
+      _.times(4, this.skipTest.bind(this));
+      _.times(5, this.failTest.bind(this));
     });
@@ -127,5 +127,5 @@
     runner.suite(function() {
-      _.times(2, this.passTest, this);
-      _.times(3, this.skipTest, this);
-      _.times(4, this.failTest, this);
+      _.times(2, this.passTest.bind(this));
+      _.times(3, this.skipTest.bind(this));
+      _.times(4, this.failTest.bind(this));
     });
@@ -132,0 +132,0 @@

spec/runnerMock.js

@@ -0,4 +1,3 @@
+var _ = require('lodash');
 
-var _ = require('underscore');
-
 var RunnerMock = function(reporter) {
@@ -5,0 +4,0 @@ this.reporter = reporter;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

5

decreased by-16.67%

Number of package files

18

increased by5.88%

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

58425

decreased by-0.05%

Lines of code

253

decreased by-1.56%

Dependency changes

• + Addedgrowl@1.10.5(transitive)

• - Removedgrowl@1.7.0(transitive)

• Updatedgrowl@^1.9.2