jsftp - npm Package Compare versions

Comparing version 0.2.1 to 0.2.2

jsftp_test.js

@@ -20,6 +20,6 @@ /*
 var FTPCredentials = {
-    host: "",
-    user: "",
+    host: "sergimansilla.com",
+    user: "fjakobs",
     port: 21,
-    pass: ""
+    pass: "lecatoc"
 };
@@ -26,0 +26,0 @@

jsftp.js

@@ -8,12 +8,7 @@ /*
 
-"use strict";
-
-var S;
 var Net = require("net");
 var ftpPasv = require("./lib/ftpPasv");
 var Parser = require('./lib/ftpParser');
+var S = require("streamer");
 
-try { S = require("streamer"); }
-catch (e) { S = require("./support/streamer/core"); }
-
 var slice = Array.prototype.slice;
@@ -75,2 +70,3 @@
 var Ftp = module.exports = function(cfg) {
+    "use strict";
     this.raw = {};
@@ -178,3 +174,3 @@ this.options = cfg;
                     self.connecting = false;
-                    !err && send();
+                    send();
                 };
@@ -249,3 +245,3 @@
 (function() {
-
+    "use strict";
     this.addCmdListener = function(listener) {
@@ -558,3 +554,3 @@ if (this.cmdListeners.indexOf(listener) === -1)
             cmd: "retr " + filePath,
-            pasvCallback: callback,
+            pasvCallback: callback
         });
@@ -570,3 +566,4 @@ };
                 var socket = self.dataConn.socket;
-                socket.writable && socket.end(buffer);
+                if (socket.writable)
+                    socket.end(buffer);
             },
@@ -605,2 +602,20 @@ pasvCallback: callback
     this.ls = function(filePath, callback) {
+        var entriesToList = function(err, entries) {
+            if (err)
+                return callback(err, entries);
+
+            if (!entries)
+                return callback(null, []);
+
+            callback(null,
+                (entries.text || entries)
+                    .split(/\r\n|\n/)
+                    .map(function(entry) {
+                        return Parser.entryParser(entry.replace("\n", ""));
+                    })
+                    // Flatten the array
+                    .filter(function(value){ return !!value; })
+            );
+        };
+
         if (this.useList) {
@@ -630,19 +645,3 @@ this.list(filePath, entriesToList);
 
-        function entriesToList(err, entries) {
-            if (err)
-                return callback(err, entries);
 
-            if (!entries)
-                return callback(null, []);
-
-            callback(null,
-                (entries.text || entries)
-                    .split(/\r\n|\n/)
-                    .map(function(entry) {
-                        return Parser.entryParser(entry.replace("\n", ""));
-                    })
-                    // Flatten the array
-                    .filter(function(value){ return !!value; })
-            );
-        }
     };
@@ -649,0 +648,0 @@

lib/ftpParser_test.js

@@ -44,4 +44,2 @@ /*
 
-
-
         var unixEntries = [
@@ -48,0 +46,0 @@ {

lib/ftpParser.js

@@ -10,3 +10,2 @@ /**
 "use strict";
-
 var RE_SERVER_RESPONSE = /^(\d\d\d)(.*)/;
@@ -216,3 +215,2 @@ var RE_MULTI_RESPONSE = /^(\d\d\d)-/;
             var time = group[2].replace(/(\d{2}):(\d{2})([AP]M)/, replacer);
-
             var date = new Date(group[1] + " " + time).getTime();
@@ -219,0 +217,0 @@ var dirString = group[3];

lib/ftpPasv.js

@@ -8,4 +8,2 @@ /*
 
-"use strict";
-
 var Net = require("net");
@@ -17,2 +15,3 @@ var S;
 module.exports = function(cfg) {
+    "use strict";
     var data;
@@ -19,0 +18,0 @@ var callback = cfg.callback;

package.json

 {
   "name": "jsftp",
   "id": "jsftp",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "A sane FTP client implementation for NodeJS",
   "keywords": [ "ftp", "streams", "files", "server", "client", "async" ],
-  "author": "Sergi Mansilla <[e-mail]>",
+  "author": "Sergi Mansilla <[e-mail]> (http://www.sergimansilla.com)",
   "homepage": "https://github.com/sergi/jsftp",
@@ -14,3 +14,3 @@ "repository": {
   "bugs": {
-    "web": "https://github.com/sergi/jsftp/issues"
+    "url": "https://github.com/sergi/jsftp/issues"
   },
@@ -25,3 +25,3 @@ "dependencies": {
   "engines": {
-    "node": ">=0.4.x"
+    "node": ">=0.4"
   },
@@ -28,0 +28,0 @@ "scripts": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Native code

Supply chain risk

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Improved metrics

Number of low maintenance alerts

1

decreased by-50%

Number of low supply chain risk alerts

2

decreased by-33.33%

Worsened metrics

Total package byte prevSize

212180

decreased by-75.74%

Number of package files

25

decreased by-45.65%

Lines of code

1684

decreased by-53.04%

No dependency changes