json-schema-to-typescript - npm Package Compare versions

Comparing version 1.2.1 to 1.2.2

package.json

 {
   "name": "json-schema-to-typescript",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "compile json schema to typescript typings",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/index.ts

@@ -168,3 +168,8 @@ import { JSONSchema } from './JSONSchema'
     let type = this.createTsType(rule)
-    type.id = type.id || rule.id || rule.title
+    if (!type.id) {
+      // the type is not declared, let's check if we should declare it or keep it inline
+      type.id = rule.id || rule.title
+      if (type.id)
+        this.declareType(type, type.id, type.id)
+    }
     type.description = type.description || rule.description
@@ -171,0 +176,0 @@ return type

src/TsTypes.ts

@@ -150,3 +150,3 @@ import { camelCase, upperFirst } from 'lodash'
             decl += ';'
-          if (settings.propertyDescription && _.type.description)
+          if (settings.propertyDescription && _.type.description && !_.type.id)
             decl += ' // ' + _.type.description
@@ -153,0 +153,0 @@ return decl

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64140

increased by1.07%

Number of package files

27

increased by3.85%

Lines of code

1796

increased by1.53%

No dependency changes