juice - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

History.md

@@ -0,1 +1,8 @@
+0.3.3 / 2013-04-08
+==================
+
+ * fix resolving file:// paths on windows (thanks Mirco Zeiss)
+ * fix crash during cleanup. (thanks Ger Hobbelt)
+ * update superagent to 0.14.0
+
 0.3.2 / 2013-03-26
@@ -2,0 +9,0 @@ ==================

lib/juice.js

@@ -24,2 +24,3 @@
   , assert = require('assert')
+  , os = require('os')
   , styleSelector = new Selector('<style attribute>', [1, 0, 0, 0])
@@ -67,3 +68,3 @@ , importantSelector = new Selector('<!important>', [2, 0, 0, 0])
   editedElements.forEach(setStyleAttrs);
-  
+
   function handleRule(rule) {
@@ -166,3 +167,7 @@ var sel = rule[0]
      var inner = document.innerHTML;
-     document.parentWindow.close();
+     // free the associated memory
+     // with lazily created parentWindow
+     try {
+       document.parentWindow.close();
+     } catch (cleanupErr) {}
      callback(null, inner);
@@ -188,3 +193,4 @@ }
     options = getDefaultOptions(options); // so we can mutate options without guilt
-    options.url = options.url || ("file://" + path.resolve(process.cwd(), filePath));
+    var slashes = os.platform() === 'win32' ? '\\\\' : '//';
+    options.url = options.url || ("file:" + slashes + path.resolve(process.cwd(), filePath));
     juiceContent(content, options, callback);
@@ -200,3 +206,5 @@ });
   // with lazily created parentWindow
-  document.parentWindow.close();
+  try {
+    document.parentWindow.close();
+  } catch (cleanupErr) {}
   return inner;
@@ -203,0 +211,0 @@ }

package.json

 {
   "name": "juice",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Inlines css into html source",
@@ -34,3 +34,3 @@ "bin": "./bin/juice",
     "batch": "~0.3.2",
-    "superagent": "~0.13.0",
+    "superagent": "~0.14.0",
     "commander": "~1.1.1",
@@ -37,0 +37,0 @@ "slick": "~1.10.0"

No alert changes

Improved metrics

Total package byte prevSize

24168

increased by1.8%

Lines of code

498

increased by1.63%

Dependency changes

• + Addeddebug@0.7.4(transitive)

• + Addedemitter-component@1.0.0(transitive)

• + Addedqs@0.6.5(transitive)

• + Addedsuperagent@0.14.9(transitive)

• - Removedemitter-component@0.0.6(transitive)

• - Removedqs@0.5.2(transitive)

• - Removedsuperagent@0.13.0(transitive)

• Updatedsuperagent@~0.14.0