karma-jasmine - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="1.1.1"></a>
+## [1.1.1](https://github.com/karma-runner/karma-jasmine/compare/v1.1.0...v1.1.1) (2017-12-01)
+
+
+### Features
+
+* Propagate errors thrown in afterAll blocks ([f3fa264](https://github.com/karma-runner/karma-jasmine/commit/f3fa264)), closes [#161](https://github.com/karma-runner/karma-jasmine/issues/161)
+
+
+
 <a name="1.1.0"></a>
@@ -2,0 +12,0 @@ # [1.1.0](https://github.com/karma-runner/karma-jasmine/compare/v1.0.2...v1.1.0) (2016-12-09)

lib/adapter.js

@@ -83,3 +83,3 @@ (function(window) {
   for (var i = 0; i < dirtyRelevantStack.length; i += 1) {
-    if (step.message && step.message.indexOf(dirtyRelevantStack[i]) === -1) {
+    if (typeof step.message === 'string' && step.message.indexOf(dirtyRelevantStack[i]) === -1) {
       // Stack entry is not in the message,
@@ -176,2 +176,14 @@ // we consider it to be a relevant stack:
 
+  function handleGlobalErrors (result) {
+    if (result.failedExpectations && result.failedExpectations.length) {
+      var message = 'An error was thrown in afterAll'
+      var steps = result.failedExpectations
+      for (var i = 0, l = steps.length; i < l; i++) {
+        message += '\n' + formatFailedStep(steps[i])
+      }
+
+      tc.error(message)
+    }
+  }
+
   /**
@@ -198,2 +210,6 @@ * Jasmine 2.0 dispatches the following events:
     result = result || {}
+
+    // Any errors in top-level afterAll blocks are given here.
+    handleGlobalErrors(result)
+
     tc.complete({
@@ -218,2 +234,6 @@ order: result.order,
 
+    // Any errors in afterAll blocks are given here, except for top-level
+    // afterAll blocks.
+    handleGlobalErrors(result)
+
     currentSuite = currentSuite.parent
@@ -220,0 +240,0 @@ }

package.json

 {
   "name": "karma-jasmine",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "A Karma plugin - adapter for Jasmine testing framework.",
@@ -45,8 +45,9 @@ "main": "lib/index.js",
     "Mark Ethan Trostler <[e-mail]>",
+    "Friedel Ziegelmayer <[e-mail]>",
     "olegskl <[e-mail]>",
-    "Friedel Ziegelmayer <[e-mail]>",
     "dignifiedquire <[e-mail]>",
     "Cornelius Schmale <[e-mail]>",
+    "Friedel Ziegelmayer <[e-mail]>",
     "Arthur Thornton <[e-mail]>",
-    "Friedel Ziegelmayer <[e-mail]>",
+    "Patrick McGuckin <[e-mail]>",
     "Richard Park <[e-mail]>",
@@ -61,2 +62,3 @@ "Sergey Tatarintsev <[e-mail]>",
     "Georgii Dolzhykov <[e-mail]>",
+    "Jacob Trimble <[e-mail]>",
     "Marek Vavrecan <[e-mail]>",
@@ -63,0 +65,0 @@ "Matthew Hill <[e-mail]>",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

22134

increased by4.86%

Lines of code

415

increased by3.75%

No dependency changes