kinvey-flex-sdk - npm Package Compare versions

Comparing version 2.0.2 to 2.0.3

CHANGELOG.md

 ## Changelog
 
+### 2.0.3
+* Fixed bug which broke push module functionality in FSR-hosted services
+
 ### 2.0.2
@@ -4,0 +7,0 @@ * Fixed top-level errors to return JSON, fixing the bug where an invalid shared secret would generate the wrong error

lib/service/moduleGenerator.js

@@ -122,7 +122,7 @@ /**
     dataStore: dataStore(appMetadata, requestMetadata, taskMetadata),
-    email: email(proxyURL, taskMetadata, proxyTaskEmitter),
+    email: email(proxyURL, appMetadata, taskMetadata, proxyTaskEmitter),
     groupStore: groupStore(appMetadata, requestMetadata, taskMetadata),
     kinveyEntity: entity(appMetadata._id, useBSONObjectId),
     kinveyDate,
-    push: push(proxyURL, taskMetadata, proxyTaskEmitter),
+    push: push(proxyURL, appMetadata, taskMetadata, proxyTaskEmitter),
     Query,
@@ -129,0 +129,0 @@ requestContext: requestContext(requestMetadata),

lib/service/modules/email.js

@@ -18,3 +18,3 @@ /**
 
-function emailModule(proxyURL, taskMetadata, proxyTaskEmitter) {
+function emailModule(proxyURL, appMetadata, taskMetadata, proxyTaskEmitter) {
   function send(from, to, subject, textBody, replyTo, htmlBody, cc, bcc, callback) {
@@ -58,3 +58,8 @@ // Abort if required email field params are not specified
       url: `${proxyURL}/email/send`,
+      auth: {
+        user: appMetadata._id,
+        pass: appMetadata.mastersecret
+      },
       headers: {
+        'x-kinvey-app-id': appMetadata._id,
         'x-kinvey-container-id': taskMetadata.containerId,
@@ -61,0 +66,0 @@ 'x-kinvey-task-id': taskMetadata.taskId,

lib/service/modules/push.js

@@ -22,3 +22,8 @@ /**
 
-function kinveyPushModule(proxyURL, taskMetadata, proxyTaskEmitter) {
+function kinveyPushModule(proxyURL, appMetadata, taskMetadata, proxyTaskEmitter) {
+  const authHeader = {
+    user: appMetadata._id,
+    pass: appMetadata.mastersecret
+  };
+
   function sendMessage(userEntities, message, callback) {
@@ -37,3 +42,5 @@ let proxyShouldWaitForConfirmation = 'true';
       url: `${proxyURL}/push/sendMessage`,
+      auth: authHeader,
       headers: {
+        'x-kinvey-app-id': appMetadata._id,
         'x-kinvey-container-id': taskMetadata.containerId,
@@ -71,3 +78,5 @@ 'x-kinvey-task-id': taskMetadata.taskId,
       url: `${proxyURL}/push/sendBroadcast`,
+      auth: authHeader,
       headers: {
+        'x-kinvey-app-id': appMetadata._id,
         'x-kinvey-container-id': taskMetadata.containerId,
@@ -74,0 +83,0 @@ 'x-kinvey-task-id': taskMetadata.taskId,

package.json

 {
   "name": "kinvey-flex-sdk",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "SDK for creating Kinvey Flex Services",
@@ -5,0 +5,0 @@ "engines": {

test/lib/modules/email.test.js

@@ -26,2 +26,6 @@ /**
   const fakeProxyURL = 'http://proxy.proxy';
+  const appMetadata = {
+    _id: 'kid_abcd1234',
+    mastersecret: '12345'
+  };
   const taskMetadata = {
@@ -39,3 +43,3 @@ taskId: 'abcd1234',
     emailModule = require('../../../lib/service/modules/email');
-    emailInstance = emailModule(fakeProxyURL, taskMetadata, emitter);
+    emailInstance = emailModule(fakeProxyURL, appMetadata, taskMetadata, emitter);
     return done();
@@ -52,2 +56,9 @@ });
   });
+  it('appends authorization header details to the request object', (done) => {
+    requestStub.post.callsArg(1);
+    (() => emailInstance.send('from', 'to', 'subject', 'textBody')).should.not.throw();
+    requestStub.post.args[0][0].auth.user.should.eql(appMetadata._id);
+    requestStub.post.args[0][0].auth.pass.should.eql(appMetadata.mastersecret);
+    return done();
+  });
   it('should include x-kinvey-wait-for-confirmation = false if no callback is specified', (done) => {
@@ -54,0 +65,0 @@ requestStub.post.callsArg(1);

test/lib/modules/push.test.js

@@ -36,2 +36,6 @@ /**
   const fakeProxyURL = 'http://proxy.proxy';
+  const appMetadata = {
+    _id: 'kid_abcd1234',
+    mastersecret: '12345'
+  };
   const taskMetadata = {
@@ -49,3 +53,3 @@ taskId: 'abcd1234',
     pushModule = require('../../../lib/service/modules/push');
-    pushInstance = pushModule(fakeProxyURL, taskMetadata, emitter);
+    pushInstance = pushModule(fakeProxyURL, appMetadata, taskMetadata, emitter);
     return done();
@@ -71,2 +75,9 @@ });
     });
+    it('appends authorization header details to the request object', (done) => {
+      requestStub.post.callsArg(1);
+      (() => pushInstance.send(recipients, 'hello')).should.not.throw();
+      requestStub.post.args[0][0].auth.user.should.eql(appMetadata._id);
+      requestStub.post.args[0][0].auth.pass.should.eql(appMetadata.mastersecret);
+      return done();
+    });
     it('should include x-kinvey-wait-for-confirmation = false if no callback is specified', (done) => {
@@ -73,0 +84,0 @@ requestStub.post.callsArg(1);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

495227

increased by0.29%

Lines of code

9273

increased by0.38%

Worsened metrics

Number of medium supply chain risk alerts

3

increased by50%

No dependency changes