knifecycle - npm Package Compare versions

Comparing version 10.0.2 to 10.0.3-beta.0

CHANGELOG.md

@@ -0,1 +1,10 @@
+## [10.0.3-beta.0](https://github.com/nfroidure/knifecycle/compare/v10.0.2...v10.0.3-beta.0) (2020-10-16)
+
+
+### Bug Fixes
+
+* **utils:** fix services mappings ([9c2b2be](https://github.com/nfroidure/knifecycle/commit/9c2b2be6f9bf72726db643fc1d1d1b17991c1d32))
+
+
+
 ## [10.0.2](https://github.com/nfroidure/knifecycle/compare/v10.0.1...v10.0.2) (2020-09-15)
@@ -2,0 +11,0 @@

dist/util.js

@@ -264,8 +264,8 @@ "use strict";
   const dedupedDependencies = currentDependencies.filter(({
-    mappedName
+    serviceName
   }) => {
     const declarationIsOverridden = addedDependencies.some(({
-      mappedName: addedMappedName
+      serviceName: addedServiceName
     }) => {
-      return addedMappedName === mappedName;
+      return addedServiceName === serviceName;
     });
@@ -272,0 +272,0 @@ return !declarationIsOverridden;

dist/util.mocha.js

@@ -335,25 +335,41 @@ "use strict";
     const baseProvider = (0, _util.inject)(['?TEST'], aProvider);
-    const newInitializer = (0, _util.alsoInject)(['ENV', '?NODE_ENV', '?TEST', 'TEST2', 'mysql>db'], (0, _util.alsoInject)(['ENV', 'NODE_ENV', '?TEST', '?TEST2', 'mysql'], baseProvider));
+    const newInitializer = (0, _util.alsoInject)(['ENV', '?NODE_ENV', '?TEST', 'TEST2', 'db>mysql'], (0, _util.alsoInject)(['ENV', 'NODE_ENV', '?TEST', '?TEST2', 'mysql'], baseProvider));
 
     _assert.default.notEqual(newInitializer, baseProvider);
 
-    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['mysql', 'ENV', 'NODE_ENV', '?TEST', 'TEST2', 'mysql>db']);
+    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['mysql', 'ENV', 'NODE_ENV', '?TEST', 'TEST2', 'db>mysql']);
+  });
+  it('should preserve single optional dependencies', () => {
+    const baseProvider = (0, _util.inject)(['ENV', '?TEST'], aProvider);
+    const newInitializer = (0, _util.alsoInject)(['ENV', '?TEST2'], (0, _util.alsoInject)(['ENV', '?TEST3'], baseProvider));
 
-    it('should preserve single optional dependencies', () => {
-      const baseProvider = (0, _util.inject)(['ENV', '?TEST'], aProvider);
-      const newInitializer = (0, _util.alsoInject)(['ENV', '?TEST2'], (0, _util.alsoInject)(['ENV', '?TEST3'], baseProvider));
+    _assert.default.notEqual(newInitializer, baseProvider);
 
-      _assert.default.notEqual(newInitializer, baseProvider);
+    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['?TEST', '?TEST3', 'ENV', '?TEST2']);
+  });
+  it('should preserve mapped dependencies', () => {
+    const baseProvider = (0, _util.inject)(['mysql', '?sftp'], aProvider);
+    const newInitializer = (0, _util.alsoInject)(['db>mysql', '?ftp>sftp'], baseProvider);
+    console.log(newInitializer[_util.SPECIAL_PROPS.INJECT]);
 
-      _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['ENV', '?TEST', '?TEST2', '?TEST3']);
-    });
+    _assert.default.notEqual(newInitializer, baseProvider);
+
+    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['mysql', '?sftp', 'db>mysql', '?ftp>sftp']);
   });
-  it('should solve final dependencies name clash', () => {
+  it('should solve dependencies alias name clash', () => {
     const baseProvider = (0, _util.inject)(['?TEST'], aProvider);
-    const newInitializer = (0, _util.alsoInject)(['ENV', '?NODE_ENV', '?TEST', 'mysql>db', 'log'], (0, _util.alsoInject)(['ENV', 'NODE_ENV', '?TEST', 'db', 'logger>log'], baseProvider));
+    const newInitializer = (0, _util.alsoInject)(['ENV', '?NODE_ENV', '?TEST', 'db>mysql', '?log>logly'], (0, _util.alsoInject)(['ENV', 'NODE_ENV', '?TEST', 'db>pg', '?log>logger'], baseProvider));
 
     _assert.default.notEqual(newInitializer, aProvider);
 
-    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['ENV', 'NODE_ENV', '?TEST', 'mysql>db', 'log']);
+    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['ENV', 'NODE_ENV', '?TEST', 'db>mysql', '?log>logly']);
   });
+  it('should solve dependencies alias name clash', () => {
+    const baseProvider = (0, _util.inject)(['?TEST'], aProvider);
+    const newInitializer = (0, _util.alsoInject)(['ENV', '?NODE_ENV', '?TEST', 'db>mysql', '?log>logly'], (0, _util.alsoInject)(['ENV', 'NODE_ENV', '?TEST', 'db>pg', '?log>logger'], baseProvider));
+
+    _assert.default.notEqual(newInitializer, aProvider);
+
+    _assert.default.deepEqual(newInitializer[_util.SPECIAL_PROPS.INJECT], ['ENV', 'NODE_ENV', '?TEST', 'db>mysql', '?log>logly']);
+  });
 });
@@ -962,9 +978,16 @@ describe('parseInjections', () => {
   it('should work', () => {
-    _assert.default.deepEqual((0, _util.parseDependencyDeclaration)('pgsql>db'), {
-      serviceName: 'pgsql',
-      mappedName: 'db',
+    _assert.default.deepEqual((0, _util.parseDependencyDeclaration)('db>pgsql'), {
+      serviceName: 'db',
+      mappedName: 'pgsql',
       optional: false
     });
   });
+  it('should work with unmapped names', () => {
+    _assert.default.deepEqual((0, _util.parseDependencyDeclaration)('?pgsql'), {
+      serviceName: 'pgsql',
+      mappedName: 'pgsql',
+      optional: true
+    });
+  });
 });
 //# sourceMappingURL=util.mocha.js.map

package.json

 {
   "name": "knifecycle",
-  "version": "10.0.2",
+  "version": "10.0.3-beta.0",
   "description": "Manage your NodeJS processes's lifecycle automatically with an unobtrusive dependency injection implementation.",
@@ -5,0 +5,0 @@ "main": "dist/index",

src/util.js

@@ -249,6 +249,6 @@ import YError from 'yerror';
   const dedupedDependencies = currentDependencies
-    .filter(({ mappedName }) => {
+    .filter(({ serviceName }) => {
       const declarationIsOverridden = addedDependencies.some(
-        ({ mappedName: addedMappedName }) => {
-          return addedMappedName === mappedName;
+        ({ serviceName: addedServiceName }) => {
+          return addedServiceName === serviceName;
         },
@@ -255,0 +255,0 @@ );

src/util.mocha.js

@@ -291,3 +291,3 @@ import assert from 'assert';
     const newInitializer = alsoInject(
-      ['ENV', '?NODE_ENV', '?TEST', 'TEST2', 'mysql>db'],
+      ['ENV', '?NODE_ENV', '?TEST', 'TEST2', 'db>mysql'],
       alsoInject(['ENV', 'NODE_ENV', '?TEST', '?TEST2', 'mysql'], baseProvider),
@@ -303,28 +303,41 @@ );
       'TEST2',
-      'mysql>db',
+      'db>mysql',
     ]);
+  });
 
-    it('should preserve single optional dependencies', () => {
-      const baseProvider = inject(['ENV', '?TEST'], aProvider);
-      const newInitializer = alsoInject(
-        ['ENV', '?TEST2'],
-        alsoInject(['ENV', '?TEST3'], baseProvider),
-      );
+  it('should preserve single optional dependencies', () => {
+    const baseProvider = inject(['ENV', '?TEST'], aProvider);
+    const newInitializer = alsoInject(
+      ['ENV', '?TEST2'],
+      alsoInject(['ENV', '?TEST3'], baseProvider),
+    );
 
-      assert.notEqual(newInitializer, baseProvider);
-      assert.deepEqual(newInitializer[SPECIAL_PROPS.INJECT], [
-        'ENV',
-        '?TEST',
-        '?TEST2',
-        '?TEST3',
-      ]);
-    });
+    assert.notEqual(newInitializer, baseProvider);
+    assert.deepEqual(newInitializer[SPECIAL_PROPS.INJECT], [
+      '?TEST',
+      '?TEST3',
+      'ENV',
+      '?TEST2',
+    ]);
   });
 
-  it('should solve final dependencies name clash', () => {
+  it('should preserve mapped dependencies', () => {
+    const baseProvider = inject(['mysql', '?sftp'], aProvider);
+    const newInitializer = alsoInject(['db>mysql', '?ftp>sftp'], baseProvider);
+    console.log(newInitializer[SPECIAL_PROPS.INJECT]);
+    assert.notEqual(newInitializer, baseProvider);
+    assert.deepEqual(newInitializer[SPECIAL_PROPS.INJECT], [
+      'mysql',
+      '?sftp',
+      'db>mysql',
+      '?ftp>sftp',
+    ]);
+  });
+
+  it('should solve dependencies alias name clash', () => {
     const baseProvider = inject(['?TEST'], aProvider);
     const newInitializer = alsoInject(
-      ['ENV', '?NODE_ENV', '?TEST', 'mysql>db', 'log'],
+      ['ENV', '?NODE_ENV', '?TEST', 'db>mysql', '?log>logly'],
       alsoInject(
-        ['ENV', 'NODE_ENV', '?TEST', 'db', 'logger>log'],
+        ['ENV', 'NODE_ENV', '?TEST', 'db>pg', '?log>logger'],
         baseProvider,
@@ -339,6 +352,26 @@ ),
       '?TEST',
-      'mysql>db',
-      'log',
+      'db>mysql',
+      '?log>logly',
     ]);
   });
+
+  it('should solve dependencies alias name clash', () => {
+    const baseProvider = inject(['?TEST'], aProvider);
+    const newInitializer = alsoInject(
+      ['ENV', '?NODE_ENV', '?TEST', 'db>mysql', '?log>logly'],
+      alsoInject(
+        ['ENV', 'NODE_ENV', '?TEST', 'db>pg', '?log>logger'],
+        baseProvider,
+      ),
+    );
+
+    assert.notEqual(newInitializer, aProvider);
+    assert.deepEqual(newInitializer[SPECIAL_PROPS.INJECT], [
+      'ENV',
+      'NODE_ENV',
+      '?TEST',
+      'db>mysql',
+      '?log>logly',
+    ]);
+  });
 });
@@ -879,8 +912,16 @@
   it('should work', () => {
-    assert.deepEqual(parseDependencyDeclaration('pgsql>db'), {
-      serviceName: 'pgsql',
-      mappedName: 'db',
+    assert.deepEqual(parseDependencyDeclaration('db>pgsql'), {
+      serviceName: 'db',
+      mappedName: 'pgsql',
       optional: false,
     });
   });
+
+  it('should work with unmapped names', () => {
+    assert.deepEqual(parseDependencyDeclaration('?pgsql'), {
+      serviceName: 'pgsql',
+      mappedName: 'pgsql',
+      optional: true,
+    });
+  });
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1064447

increased by0.81%

Lines of code

11638

increased by0.67%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes