knox-ec2-role - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

index.js

 var AWS = require('aws-sdk')
   , debug = require('debug')('knox-ec2-role')
   , knox = require('knox')
-  , Promise = require('bluebird')
 
 module.exports = {
   authenticate: function (conf, httpOptions) {
-    return new Promise(function (resolve, reject) {
-      if (!conf) {
-        conf = {}
-      }
-      Object.assign(AWS.config.httpOptions, httpOptions)
-      var metadata = new AWS.MetadataService()
-      debug('loading credentials from aws metadata')
-      metadata.loadCredentials(function (err, creds) {
-        if (err) {
-          debug('error: ', err)
-          reject(err)
-          return
-        }
+    conf = conf || {}
+    var metadata = new AWS.MetadataService()
+    Object.assign(AWS.config.httpOptions, httpOptions)
+    return metadata.loadCredentials().promise()
+      .then(function (creds) {
+        debug('loading credentials from aws metadata')
         debug(creds)
@@ -25,11 +17,10 @@ Object.assign(conf, {key: creds.AccessKeyId, secret: creds.SecretAccessKey, token: creds.Token})
           var client = knox.createClient(conf)
-          resolve(client)
+          return Promise.resolve(client)
         } catch (e) {
           debug(e)
           debug(e.stack)
-          reject(e)
+          return Promise.reject(e)
         }
       })
-    })
   }
 }

package.json

@@ -9,7 +9,5 @@ {
   ],
-  "version": "0.0.2",
+  "version": "0.0.3",
   "dependencies": {
     "aws-sdk": "^2.28.0",
-    "bluebird": "^3.5.0",
-    "chai": "^3.5.0",
     "knox": "^0.9.2"
@@ -30,2 +28,4 @@ },
     "aws-sdk-mock": "^1.6.1",
+    "chai-as-promised": "^6.0.0",
+    "chai": "^3.5.0",
     "dotenv": "^4.0.0",
@@ -32,0 +32,0 @@ "eslint": "^1.4.1",

test/index.test.js

@@ -0,1 +1,2 @@
+'use strict'
 var chai = require('chai')
@@ -5,14 +6,19 @@ , expect = chai.expect
 , AWS = require('aws-sdk-mock')
-, knoxec2
+chai.use(require('chai-as-promised'))
 
-AWS.mock('MetadataService', 'loadCredentials', function (callback) {
-  callback(null, {AccessKeyId: process.env.ACCESS_KEY_ID
-    , SecretAccessKey: process.env.SECRET_ACCESS_KEY})
-})
-knoxec2 = proxyquire('../index.js', { 'AWS': AWS })
-
-describe('knox-ec2-role', function () {
+describe('uploading files', function () {
+  let knoxec2
+  before(function () {
+    AWS.mock('MetadataService', 'loadCredentials', function (callback) {
+      callback(null, {AccessKeyId: process.env.ACCESS_KEY_ID
+        , SecretAccessKey: process.env.SECRET_ACCESS_KEY})
+    })
+    knoxec2 = proxyquire('../index.js', { 'AWS': AWS })
+  })
+  after(function () {
+    knoxec2 = null
+    AWS.restore('MetadataService')
+  })
   it('should upload file', function (done) {
-    var defaultConf = {bucket: process.env.K2_BUCKET}
-    knoxec2.authenticate(defaultConf, {timeout: 5000})
+    knoxec2.authenticate({bucket: process.env.K2_BUCKET}, {timeout: 5000})
       .then(function (client) {
@@ -31,7 +37,37 @@ var object = { foo: 'bar' }
       })
-      .catch(function (e) {
-        expect(e).to.not.be.true
-        done()
+  })
+  it('should fail to upload with a bad bucket', function (done) {
+    knoxec2.authenticate({bucket: process.env.K2_BUCKET + 'xxx'}, {timeout: 5000})
+      .then(function (client) {
+        var object = { foo: 'bar' }
+        , string = JSON.stringify(object)
+        , req = client.put('/test/obj.json', {
+            'Content-Length': Buffer.byteLength(string)
+          , 'Content-Type': 'application/json'
+        })
+        req.on('response', function (res) {
+          expect(res.statusCode).to.equal(404)
+          done()
+        })
+        req.end(string)
       })
   })
 })
+
+describe('failed metadata test', function () {
+  let knoxec2
+  before(function () {
+    AWS.mock('MetadataService', 'loadCredentials', function (callback) {
+      // force error
+      callback(true)
+    })
+    knoxec2 = proxyquire('../index.js', { 'AWS': AWS })
+  })
+  after(function () {
+    knoxec2 = null
+    AWS.restore('MetadataService')
+  })
+  it('should reject a broken promise', function () {
+    return expect(knoxec2.authenticate({bucket: process.env.K2_BUCKET}, {timeout: 5000})).to.be.rejected
+  })
+})

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

54842

increased by2.28%

Dependency count

2

decreased by-50%

Lines of code

93

increased by40.91%

Worsened metrics

Dev dependency count

11

increased by22.22%

Number of low supply chain risk alerts

5

increased by66.67%

Dependency changes

• - Removedbluebird@^3.5.0

• - Removedchai@^3.5.0

• - Removedassertion-error@1.1.0(transitive)

• - Removedbluebird@3.7.2(transitive)

• - Removedchai@3.5.0(transitive)

• - Removeddeep-eql@0.1.3(transitive)

• - Removedtype-detect@0.1.11.0.0(transitive)