koa-router - npm Package Compare versions

Comparing version 6.1.0 to 6.2.0

history.md

 # History
 
+## 6.2.0
+
+- Improved router.url() [#143](https://github.com/alexmingoia/koa-router/pull/143)
+
 ## 6.1.0
@@ -7,3 +11,2 @@
   [#152](https://github.com/alexmingoia/koa-router/pulls/152)
-- Improved router.url() [#143](https://github.com/alexmingoia/koa-router/pull/143)
 - Add support for custom throw functions for 405 and 501 responses [#206](https://github.com/alexmingoia/koa-router/pull/206)
@@ -10,0 +13,0 @@

lib/layer.js

@@ -117,2 +117,3 @@ var debug = require('debug')('koa-router');
   var url = this.path;
+  var toPath = pathToRegExp.compile(url);
 
@@ -125,17 +126,12 @@ // argument is of form { key: val }
   if (args instanceof Array) {
-    for (var len = args.length, i=0; i<len; i++) {
-      url = url.replace(/:[^\/]+/, args[i]);
+    var tokens = pathToRegExp.parse(url);
+    var replace = {};
+    for (var len = tokens.length, i=0, j=0; i<len; i++) {
+      if (tokens[i].name) replace[tokens[i].name] = args[j++];
     }
+    return toPath(replace);
   }
   else {
-    for (var key in args) {
-      url = url.replace(':' + key, args[key]);
-    }
+    return toPath(params);
   }
-
-  url.split('/').forEach(function (component) {
-    url = url.replace(component, encodeURIComponent(component));
-  });
-
-  return url;
 };
@@ -142,0 +138,0 @@

package.json

@@ -13,3 +13,3 @@ {
   "author": "Alex Mingoia <[e-mail]>",
-  "version": "6.1.0",
+  "version": "6.2.0",
   "keywords": [
@@ -16,0 +16,0 @@ "koa",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

41160

decreased by-0.05%

Lines of code

808

decreased by-0.25%

No dependency changes