ldapts - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

CHANGELOG.md

@@ -0,1 +1,6 @@
+### 1.1.2
+
+  * Fix ECONNRESET issue connecting to non-secure endpoint
+  * Throw an error for each message on socket error
+
 ### 1.1.1
@@ -2,0 +7,0 @@

dist/Client.js

@@ -15,2 +15,3 @@ "use strict";
 const url_1 = require("url");
+const net = __importStar(require("net"));
 const tls = __importStar(require("tls"));
@@ -415,4 +416,4 @@ const BindRequest_1 = require("./messages/BindRequest");
         return new Promise((resolve, reject) => {
-            this.socket = tls.connect(this.port, this.host, this.clientOptions.tlsOptions);
             if (this.secure) {
+                this.socket = tls.connect(this.port, this.host, this.clientOptions.tlsOptions);
                 this.socket.once('secureConnect', () => {
@@ -423,2 +424,3 @@ this._onConnect(resolve);
             else {
+                this.socket = net.connect(this.port, this.host);
                 this.socket.once('connect', () => {
@@ -454,3 +456,14 @@ this._onConnect(resolve);
         // region Socket events handlers
-        const socketError = () => {
+        const socketError = (err) => {
+            // Clean up any pending messages
+            for (const [key, messageDetails] of Object.entries(this.messageDetailsByMessageId)) {
+                if (messageDetails.message instanceof UnbindRequest_1.UnbindRequest) {
+                    // Consider unbind as success since the connection is closed.
+                    messageDetails.resolve();
+                }
+                else {
+                    messageDetails.reject(new Error(`Socket error. Message type: ${messageDetails.message.constructor.name} (0x${messageDetails.message.protocolOperation.toString(16)})\n${err.message || err.stack || 'Unknown'}`));
+                }
+                delete this.messageDetailsByMessageId[key];
+            }
             this.socket.destroy();
@@ -484,3 +497,3 @@ };
             // Clean up any pending messages
-            for (const messageDetails of Object.values(this.messageDetailsByMessageId)) {
+            for (const [key, messageDetails] of Object.entries(this.messageDetailsByMessageId)) {
                 if (messageDetails.message instanceof UnbindRequest_1.UnbindRequest) {
@@ -493,2 +506,3 @@ // Consider unbind as success since the connection is closed.
                 }
+                delete this.messageDetailsByMessageId[key];
             }
@@ -495,0 +509,0 @@ // Cleanup handlers

package.json

 {
   "name": "ldapts",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "LDAP client",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

README.md

@@ -17,5 +17,5 @@ LDAPts
 
-const url = 'ldap://127.0.0.1:1389';
-const bindDN = 'uid=foo,dc=example,dc=com';
-const password = 'bar';
+const url = 'ldap://ldap.forumsys.com:389';
+const bindDN = 'cn=read-only-admin,dc=example,dc=com';
+const password = 'password';
 
@@ -43,6 +43,6 @@ const client = new Client({
 
-const url = 'ldap://127.0.0.1:1389';
-const bindDN = 'uid=foo,dc=example,dc=com';
-const password = 'bar';
-const searchDN = 'ou=Users,dc=example,dc=com';
+const url = 'ldaps://ldap.jumpcloud.com';
+const bindDN = 'uid=tony.stark,ou=Users,o=5be4c382c583e54de6a3ff52,dc=jumpcloud,dc=com';
+const password = 'MyRedSuitKeepsMeWarm';
+const searchDN = 'ou=Users,o=5be4c382c583e54de6a3ff52,dc=jumpcloud,dc=com';
 
@@ -64,3 +64,3 @@ const client = new Client({
     scope: 'sub',
-    filter: 'cn=Foobar',
+    filter: '(mail=[e-mail])',
   });
@@ -67,0 +67,0 @@ } catch (ex) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

257071

increased by0.72%

Lines of code

4114

increased by0.34%

Worsened metrics

Number of medium supply chain risk alerts

2

increased by100%

No dependency changes