ldapts - npm Package Compare versions

Comparing version 1.5.1 to 1.6.0

CHANGELOG.md

@@ -0,1 +1,4 @@
+### 1.6.0
+  * Fix incorrectly escaping search filter names/values. Fix #18
+
 ### 1.5.1
@@ -2,0 +5,0 @@ * Do not throw "Size limit exceeded" error if `sizeLimit` is defined and the server responds with `4` (Size limit exceeded).

dist/filters/ApproximateFilter.js

@@ -17,4 +17,4 @@ "use strict";
     writeFilter(writer) {
-        writer.writeString(this.escape(this.attribute));
-        writer.writeString(this.escape(this.value));
+        writer.writeString(this.attribute);
+        writer.writeString(this.value);
     }
@@ -21,0 +21,0 @@ matches(_ = {}, __) {

dist/filters/EqualityFilter.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const asn1_1 = require("asn1");
 const Filter_1 = require("./Filter");
@@ -21,4 +20,4 @@ const SearchFilter_1 = require("../SearchFilter");
     writeFilter(writer) {
-        writer.writeString(this.escape(this.attribute));
-        writer.writeString(this.escape(this.value), asn1_1.Ber.OctetString);
+        writer.writeString(this.attribute);
+        writer.writeString(this.value);
     }
@@ -25,0 +24,0 @@ matches(objectToCheck = {}, strictAttributeCase) {

dist/filters/ExtensibleFilter.js

@@ -43,8 +43,8 @@ "use strict";
         if (this.rule) {
-            writer.writeString(this.escape(this.rule), 0x81);
+            writer.writeString(this.rule, 0x81);
         }
         if (this.matchType) {
-            writer.writeString(this.escape(this.matchType), 0x82);
+            writer.writeString(this.matchType, 0x82);
         }
-        writer.writeString(this.escape(this.value), 0x83);
+        writer.writeString(this.value, 0x83);
         if (this.dnAttributes) {
@@ -51,0 +51,0 @@ writer.writeBoolean(this.dnAttributes, 0x84);

dist/filters/GreaterThanEqualsFilter.js

@@ -17,4 +17,4 @@ "use strict";
     writeFilter(writer) {
-        writer.writeString(this.escape(this.attribute));
-        writer.writeString(this.escape(this.value));
+        writer.writeString(this.attribute);
+        writer.writeString(this.value);
     }
@@ -21,0 +21,0 @@ matches(objectToCheck = {}, strictAttributeCase) {

dist/filters/LessThanEqualsFilter.js

@@ -17,4 +17,4 @@ "use strict";
     writeFilter(writer) {
-        writer.writeString(this.escape(this.attribute));
-        writer.writeString(this.escape(this.value));
+        writer.writeString(this.attribute);
+        writer.writeString(this.value);
     }
@@ -21,0 +21,0 @@ matches(objectToCheck = {}, strictAttributeCase) {

dist/filters/PresenceFilter.js

@@ -16,6 +16,5 @@ "use strict";
     writeFilter(writer) {
-        const escapedAttribute = this.escape(this.attribute);
         // tslint:disable-next-line:no-increment-decrement
-        for (let i = 0; i < escapedAttribute.length; i++) {
-            writer.writeByte(escapedAttribute.charCodeAt(i));
+        for (let i = 0; i < this.attribute.length; i++) {
+            writer.writeByte(this.attribute.charCodeAt(i));
         }
@@ -22,0 +21,0 @@ }

dist/filters/SubstringFilter.js

@@ -54,14 +54,14 @@ "use strict";
     writeFilter(writer) {
-        writer.writeString(this.escape(this.attribute));
+        writer.writeString(this.attribute);
         writer.startSequence();
         if (this.initial) {
-            writer.writeString(this.escape(this.initial), 0x80);
+            writer.writeString(this.initial, 0x80);
         }
         if (this.any && this.any.length) {
             for (const anyItem of this.any) {
-                writer.writeString(this.escape(anyItem), 0x81);
+                writer.writeString(anyItem, 0x81);
             }
         }
         if (this.final) {
-            writer.writeString(this.escape(this.final), 0x82);
+            writer.writeString(this.final, 0x82);
         }
@@ -68,0 +68,0 @@ writer.endSequence();

package.json

 {
   "name": "ldapts",
-  "version": "1.5.1",
+  "version": "1.6.0",
   "description": "LDAP client",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

274667

decreased by-0.25%

Lines of code

4337

decreased by-0.05%

No dependency changes