libp2p-mdns - npm Package Compare versions

Comparing version 0.14.2 to 0.14.3

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="0.14.3"></a>
+## [0.14.3](https://github.com/libp2p/js-libp2p-mdns/compare/v0.14.2...v0.14.3) (2020-08-07)
+
+
+### Bug Fixes
+
+* ensure event handlers are removed on MulticastDNS.stop ([#96](https://github.com/libp2p/js-libp2p-mdns/issues/96)) ([9fea1f6](https://github.com/libp2p/js-libp2p-mdns/commit/9fea1f6))
+
+
+
 <a name="0.14.2"></a>
@@ -2,0 +12,0 @@ ## [0.14.2](https://github.com/libp2p/js-libp2p-mdns/compare/v0.14.1...v0.14.2) (2020-07-02)

package.json

 {
   "name": "libp2p-mdns",
-  "version": "0.14.2",
+  "version": "0.14.3",
   "description": "Node.js libp2p mDNS discovery implementation for peer discovery",
@@ -60,7 +60,8 @@ "leadMaintainer": "Jacob Heun <[e-mail]>",
     "ᴠɪᴄᴛᴏʀ ʙᴊᴇʟᴋʜᴏʟᴍ <[e-mail]>",
+    "Alex Potsides <[e-mail]>",
     "Richard Littauer <[e-mail]>",
-    "Alex Potsides <[e-mail]>",
     "dirkmc <[e-mail]>",
-    "emersion <[e-mail]>"
+    "emersion <[e-mail]>",
+    "Hubertus Hohl <[e-mail]>"
   ]
 }

src/index.js

@@ -26,2 +26,4 @@ 'use strict'
     this._onPeer = this._onPeer.bind(this)
+    this._onMdnsQuery = this._onMdnsQuery.bind(this)
+    this._onMdnsResponse = this._onMdnsResponse.bind(this)
 
@@ -48,4 +50,4 @@ if (options.compat !== false) {
     this.mdns = multicastDNS({ port: this.port })
-    this.mdns.on('query', (event) => this._onMdnsQuery(event))
-    this.mdns.on('response', (event) => this._onMdnsResponse(event))
+    this.mdns.on('query', this._onMdnsQuery)
+    this.mdns.on('response', this._onMdnsResponse)
 
@@ -90,3 +92,3 @@ this._queryInterval = query.queryLAN(this.mdns, this.serviceTag, this.interval)
     this.mdns.removeListener('query', this._onMdnsQuery)
-    this.mdns.removeListener('query', this._onMdnsResponse)
+    this.mdns.removeListener('response', this._onMdnsResponse)
     this._goMdns && this._goMdns.removeListener('peer', this._onPeer)
@@ -93,0 +95,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

27324

increased by1.67%

Lines of code

527

increased by0.38%

No dependency changes