libp2p-tcp - npm Package Compare versions

Comparing version 0.14.3 to 0.14.4

.vscode/launch.json

@@ -13,12 +13,15 @@ {
       "args": [
+        "-u",
+        "bdd",
         "--timeout",
         "999999",
         "--colors",
-        "--grep",
-        "upgradeInbound throws",
-        "${workspaceFolder}/test/compliance.spec.js"
+        "${workspaceFolder}/test"
       ],
-      "internalConsoleOptions": "openOnSessionStart"
+      "internalConsoleOptions": "openOnSessionStart",
+      "skipFiles": [
+        "<node_internals>/**"
+      ]
     }
   ]
 }

CHANGELOG.md

@@ -0,1 +1,12 @@
+<a name="0.14.4"></a>
+## [0.14.4](https://github.com/libp2p/js-libp2p-tcp/compare/v0.14.3...v0.14.4) (2020-02-24)
+
+
+### Bug Fixes
+
+* catch thrown maConn errors in listener ([#122](https://github.com/libp2p/js-libp2p-tcp/issues/122)) ([86db568](https://github.com/libp2p/js-libp2p-tcp/commit/86db568)), closes [#121](https://github.com/libp2p/js-libp2p-tcp/issues/121)
+* remove use of assert module ([#123](https://github.com/libp2p/js-libp2p-tcp/issues/123)) ([6272876](https://github.com/libp2p/js-libp2p-tcp/commit/6272876))
+
+
+
 <a name="0.14.3"></a>
@@ -2,0 +13,0 @@ ## [0.14.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.14.2...v0.14.3) (2019-12-20)

package.json

 {
   "name": "libp2p-tcp",
-  "version": "0.14.3",
+  "version": "0.14.4",
   "description": "Node.js implementation of the TCP module that libp2p uses, which implements the interface-connection and interface-transport interfaces",
@@ -36,3 +36,3 @@ "leadMaintainer": "Jacob Heun <[e-mail]>",
   "devDependencies": {
-    "aegir": "^20.4.1",
+    "aegir": "^21.0.2",
     "chai": "^4.2.0",
@@ -42,3 +42,3 @@ "dirty-chai": "^2.0.1",
     "it-pipe": "^1.1.0",
-    "sinon": "^7.5.0",
+    "sinon": "^9.0.0",
     "streaming-iterables": "^4.1.1"
@@ -57,5 +57,14 @@ },
   "contributors": [
-    "Alan Shaw <[e-mail]>",
+    "David Dias <[e-mail]>",
+    "Jacob Heun <[e-mail]>",
+    "Stephen Whitmore <[e-mail]>",
+    "Friedel Ziegelmayer <[e-mail]>",
+    "Vasco Santos <[e-mail]>",
+    "Richard Littauer <[e-mail]>",
+    "Tom White <[e-mail]>",
     "Alan Shaw <[e-mail]>",
-    "David Dias <[e-mail]>",
+    "Pedro Teixeira <[e-mail]>",
+    "Prashanth Chandra <[e-mail]>",
+    "João Antunes <[e-mail]>",
+    "Alex Potsides <[e-mail]>",
     "Diogo Silva <[e-mail]>",
@@ -65,15 +74,4 @@ "Dmitriy Ryajov <[e-mail]>",
     "Evan Schwartz <[e-mail]>",
-    "Friedel Ziegelmayer <[e-mail]>",
-    "Greenkeeper <[e-mail]>",
-    "Jacob Heun <[e-mail]>",
-    "Jacob Heun <[e-mail]>",
-    "João Antunes <[e-mail]>",
-    "Linus Unnebäck <[e-mail]>",
-    "Pedro Teixeira <[e-mail]>",
-    "Prashanth Chandra <[e-mail]>",
-    "Richard Littauer <[e-mail]>",
-    "Stephen Whitmore <[e-mail]>",
-    "TomCoded <[e-mail]>",
-    "Vasco Santos <[e-mail]>"
+    "Linus Unnebäck <[e-mail]>"
   ]
 }

src/index.js

@@ -13,3 +13,2 @@ 'use strict'
 const { CODE_CIRCUIT, CODE_P2P } = require('./constants')
-const assert = require('assert')
 
@@ -26,3 +25,5 @@ /**
   constructor ({ upgrader }) {
-    assert(upgrader, 'An upgrader must be provided. See https://github.com/libp2p/interface-transport#upgrader.')
+    if (!upgrader) {
+      throw new Error('An upgrader must be provided. See https://github.com/libp2p/interface-transport#upgrader.')
+    }
     this._upgrader = upgrader
@@ -29,0 +30,0 @@ }

src/listener.js

@@ -23,11 +23,11 @@ 'use strict'
 
-    const maConn = toConnection(socket, { listeningAddr })
-    log('new inbound connection %s', maConn.remoteAddr)
-
+    let maConn
     let conn
     try {
+      maConn = toConnection(socket, { listeningAddr })
+      log('new inbound connection %s', maConn.remoteAddr)
       conn = await upgrader.upgradeInbound(maConn)
     } catch (err) {
-      log.error('inbound connection failed to upgrade', err)
-      return maConn.close()
+      log.error('inbound connection failed', err)
+      return maConn && maConn.close()
     }
@@ -34,0 +34,0 @@

No alert changes

Improved metrics

Total package byte prevSize

1599933

increased by0.03%

Lines of code

2182

increased by0.23%

No dependency changes