liferay-npm-build-tools-common - npm Package Compare versions

Comparing version 1.5.0 to 1.6.0-alpha.fa6ec338

lib/__tests__/plugin-logger.test.js

@@ -46,9 +46,17 @@ 'use strict';
 
-		expect(_pluginLogger2.default.get('a-key')).toBe(logger);
+		logger.info('source', 'hi');
 
+		expect(_pluginLogger2.default.get('a-key').messages.length).toBe(1);
+
 		_pluginLogger2.default.delete('a-key');
 
-		expect(_pluginLogger2.default.get('a-key')).toBeUndefined();
+		expect(_pluginLogger2.default.get('a-key').messages.length).toBe(0);
 	});
+
+	it('returns a dummy logger if no loggers are registered', function () {
+		_pluginLogger2.default.delete('a-key');
+
+		expect(_pluginLogger2.default.get('a-key')).toBeDefined();
+	});
 });
 //# sourceMappingURL=plugin-logger.test.js.map

lib/plugin-logger.js

@@ -145,3 +145,3 @@ 'use strict';
 
-	return global._PluginLogger_[key];
+	return global._PluginLogger_[key] || new PluginLogger();
 };
@@ -148,0 +148,0 @@

package.json

 {
 	"name": "liferay-npm-build-tools-common",
-	"version": "1.5.0",
+	"version": "1.6.0-alpha.fa6ec338",
 	"description": "Utility library for Liferay NPM Build Tools.",
@@ -5,0 +5,0 @@ "scripts": {

src/__tests__/plugin-logger.test.js

@@ -40,8 +40,16 @@ import PluginLogger from '../plugin-logger';
 
-		expect(PluginLogger.get('a-key')).toBe(logger);
+		logger.info('source', 'hi');
 
+		expect(PluginLogger.get('a-key').messages.length).toBe(1);
+
 		PluginLogger.delete('a-key');
 
-		expect(PluginLogger.get('a-key')).toBeUndefined();
+		expect(PluginLogger.get('a-key').messages.length).toBe(0);
 	});
+
+	it('returns a dummy logger if no loggers are registered', () => {
+		PluginLogger.delete('a-key');
+
+		expect(PluginLogger.get('a-key')).toBeDefined();
+	});
 });

src/plugin-logger.js

@@ -101,3 +101,3 @@ /**
 
-	return global._PluginLogger_[key];
+	return global._PluginLogger_[key] || new PluginLogger();
 };
@@ -104,0 +104,0 @@

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

27924

increased by3.67%

Lines of code

433

increased by2.36%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes